466484 - layout/reftests/text/444656.html fails on some machines

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

layout/reftests/text/444656.html fails on the new 1.9.1 Mac build machine that was set up (see also bug 420911 comment4, bug 420913 comment 8).

This one, however, is a bug in the test, and easy to fix.  It assumes that 55ch is enough width to hold the Hebrew alphabet twice, but not three times.  However, the assumes certain ratios between the size of the characters in the Western font (from which the 'ch' unit is going to be derived, by default) and the size of the characters in the Hebrew font.  On this machine, it seems the Hebrew font is significantly smaller.

This can be fixed by inserting a string of characters of appropriate length and using width: -moz-min-content on the test, while just sticking in that string of characters with a break in the reference.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: reftest output from log in bug 420911 comment 4

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Landed on mozilla-central (and thus also on mozilla-1.9.1):
http://hg.mozilla.org/mozilla-central/rev/81cfdc324ffb