Sunbird/Lightning should get RTL compatible theme

RESOLVED FIXED in 1.0b1

Status

defect
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: tomer, Assigned: Fallen)

Tracking

({intl, rtl})

Details

()

Attachments

(2 attachments, 2 obsolete attachments)

I am sorry to be the person to tell that, but sadly Sunbird has no RTL compatible theme at all. This blocks the release for every RTL locale. 

With a quick sanity check I've found the main screen has two issues. Other pages may also have some RTL issues, but this will require us to do a more deeply check (any script to get over every screen in the application?).


Issues on the main screen with default program configuration:
1. The day/hour table is not aligned correctly and is broken.
2. Arrows should be flipped. 

We done recently the fixes for Firefox 3.0 theme, and the linked page talks about how to do that. I will be happy to work on this, but will need some help from others, especially contacts from other RTL locales which are blocked by this issue in order to make sure solutions will also be helpful to them.
https://developer.mozilla.org/en/Making_Sure_Your_Theme_Works_with_RTL_Locales
Making Sure Your [Firefox] Theme Works with RTL Locales


http://mxr.mozilla.org/l10n-central/source/he/toolkit/chrome/global/intl.css
Our current intl.css file. Keep in mind we prefer not to add more junk to this file, and instead solve the issues from its root, which is the application default theme.
Component: he / Hebrew → General
Product: Mozilla Localizations → Calendar
QA Contact: hebrew.he → general
Target Milestone: --- → 1.0
Version: unspecified → Trunk
Tomer, the table issue happens in LTR locales as well and is not RTL specific. It goes away when you move the views (e.g. move to the next week) for the first time.
Requesting blocking Calendar 1.0, as this issue is very important to RTL locales.
Flags: blocking-calendar1.0?
> Issues on the main screen with default program configuration:
> 1. The day/hour table is not aligned correctly and is broken.

Known issue, see Bug 344561.
Posted patch Fix - v1 (obsolete) β€” β€” Splinter Review
This patch fixes the most prominent issues in the main view. It should greatly improve the situation. The only obvious thing I still saw was the cycler in the todaypane, but since this uses the same styles as thunderbird I'd say its better to fix the issue there.

When this bug is fixed, if needed please file a new one and pinpoint any remaining issues.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #361332 - Flags: review?(ssitter)
Please disregard the pinstripe/winstripe theme differences I accidentally flattened in today-pane.css, I've fixed this locally.
Comment on attachment 361332 [details] [diff] [review]
Fix - v1

>         <modehbox mode="mail,calendar" broadcaster="modeBroadcaster">
>-          <toolbarbutton id="folderview-cycler-left"
>+          <toolbarbutton id="folderview-cycler-prev"
>+                         chromedir="&locale.dir;"
>                          class="folderview-cycler"
>                          oncommand="TodayPane.cyclePaneView(-1);"/>
>-          <toolbarbutton id="folderview-cycler-right"
>+          <toolbarbutton id="folderview-cycler-next"
>+                         chromedir="&locale.dir;"

This change of the IDs makes the buttons invisible. Looks like Thunderbird defines style rules only for folderview-cycler-right and folderview-cycler-left. I suggest to keep the current IDs to actually see the buttons.

Otherwise r=ssitter. Only tested with Thunderbird 3.0b2pre on Windows XP.
Attachment #361332 - Flags: review?(ssitter) → review+
Posted patch Fix - v2 (obsolete) β€” β€” Splinter Review
This patch also fixes the mail/ code and makes the mail folderpane rtl compliant.
Attachment #361332 - Attachment is obsolete: true
Attachment #361807 - Flags: review?(philringnalda)
Whiteboard: [needs review]
Alas, poor Pinstripe. I'm not sure quite why yet, but in RTL that puts a space in between the two buttons, instead of between the buttons and the edge of the folderpane.
Whiteboard: [needs review]
Posted patch Fix - v3 β€” β€” Splinter Review
Blasted pinstripe! Instead of using a margin, I opted for a padding on the sidebarheader.
Attachment #361807 - Attachment is obsolete: true
Attachment #362600 - Flags: review?(philringnalda)
Attachment #361807 - Flags: review?(philringnalda)
Comment on attachment 362600 [details] [diff] [review]
Fix - v3

Sorry about the delay, that seems fine to me. (Other than the trailing whitespace after <!DOCTYPE bindings in minimonth.xml, anyway.)
Attachment #362600 - Flags: review?(philringnalda) → review+
This checkin needs to be postponed until after our 3.0b2 compatible milestone
Whiteboard: [after our 3.0b2 miletone]
(In reply to comment #12)

If I understand it correctly most Thunderbird theme extensions must be updated after landing the mail/ changes. Is this correct? In that case I think it should land rather soon, at least for Tb 3.0b3.
When is b3 planned? If we still want to provide a lightning version compatible with b2, this patch will break it. We could do the Thunderbird checkin asap and check in a modified version of the calendar patch, leaving this bug open for the rest of the changes, but is it really worth the effort?
Whiteboard: [after our 3.0b2 miletone] → [after our 3.0b2 milestone]
Schedule's still firming up, but roughly: freeze end of April, ship start of May.
I'm not going to hold this off any longer, its mythical that we will be ready before b3.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f7e27990b718>

-> FIXED
Group: core-security
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: blocking-calendar1.0?
Resolution: --- → FIXED
Whiteboard: [after our 3.0b2 milestone]
Not sure why this was put into the security group...
Group: core-security
Sorry, that was definitely an accident.
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.