If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Investigate if NS_FRAME_EXTERNAL_REFERENCE should be cleared when there are no weak frames for the frame

NEW
Unassigned

Status

()

Core
Layout
9 years ago
9 years ago

People

(Reporter: smaug, Unassigned)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 349844 [details] [diff] [review]
possible patch

Because of EventStateManager, quite many frames are marked to have
external reference (i.e. have one or more weak frames).
We could detect the case when there are no weak frames and remove the bit.
That would speed up nsIFrame::Destroy a bit, but it would slow down using
weak frames.

Note, pretty much always when removing a weak frame we have only 2 weak frames
in the presshell (ESM has few nsWeakFrame members) - the one we're removing
and some other. Anyway the while-loops here should be fast.
You need to log in before you can comment on or make changes to this bug.