466559 - media queries should use page size when printing

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

The media queries 'width', 'height', and 'aspect-ratio' should use the page size when printing.  jmaher has some tests for this on bug 466171, although I haven't seen them yet, and bzbarsky pointed out the bug in the code when this came up.

Here's a patch that I *think* should fix the issue (although I haven't seen the tests yet, and since jmaher has them, I'm not going to spend time rewriting them).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This fixes device-* the same way, and does a little bit of code consolidation into helper functions.

I posted http://lists.w3.org/Archives/Public/www-style/2008Dec/0017.html about whether this is the right thing for device-*, but I think it's good enough for now, and certainly a lot better than what we were doing (at least for the print preview case; it might have been a little better for print).

The tests for this patch are in bug 466171.  Once this lands, the remaining failures I see in those tests are all issues described in bug 466171 comment 11.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 351105 [details] [diff] [review]
patch

r+sr=bzbarsky

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed on mozilla-central: http://hg.mozilla.org/mozilla-central/rev/436c476d4661

Still needs to land on 1.9.1, and the tests from bug 466171 still need to land.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed on 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/af054be8c9ef

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I missed fixing 'orientation' here; it is fixed by attachment 354400 [details] [diff] [review] on bug 468645.