Closed Bug 466559 Opened 14 years ago Closed 14 years ago

media queries should use page size when printing

Categories

(Core :: CSS Parsing and Computation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.1b3

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
The media queries 'width', 'height', and 'aspect-ratio' should use the page size when printing.  jmaher has some tests for this on bug 466171, although I haven't seen them yet, and bzbarsky pointed out the bug in the code when this came up.

Here's a patch that I *think* should fix the issue (although I haven't seen the tests yet, and since jmaher has them, I'm not going to spend time rewriting them).
Flags: blocking1.9.1?
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Attached patch patchSplinter Review
This fixes device-* the same way, and does a little bit of code consolidation into helper functions.

I posted http://lists.w3.org/Archives/Public/www-style/2008Dec/0017.html about whether this is the right thing for device-*, but I think it's good enough for now, and certainly a lot better than what we were doing (at least for the print preview case; it might have been a little better for print).

The tests for this patch are in bug 466171.  Once this lands, the remaining failures I see in those tests are all issues described in bug 466171 comment 11.
Attachment #349859 - Attachment is obsolete: true
Attachment #351105 - Flags: superreview?(bzbarsky)
Attachment #351105 - Flags: review?(bzbarsky)
Comment on attachment 351105 [details] [diff] [review]
patch

r+sr=bzbarsky
Attachment #351105 - Flags: superreview?(bzbarsky)
Attachment #351105 - Flags: superreview+
Attachment #351105 - Flags: review?(bzbarsky)
Attachment #351105 - Flags: review+
Fixed on mozilla-central: http://hg.mozilla.org/mozilla-central/rev/436c476d4661

Still needs to land on 1.9.1, and the tests from bug 466171 still need to land.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs 1.9.1 landing]
Target Milestone: --- → mozilla1.9.2a1
Fixed on 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/af054be8c9ef
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing]
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b3
I missed fixing 'orientation' here; it is fixed by attachment 354400 [details] [diff] [review] on bug 468645.
See Also: → 1414600
You need to log in before you can comment on or make changes to this bug.