Closed Bug 466642 Opened 11 years ago Closed 10 years ago

Style about:config on OS X

Categories

(Toolkit :: Themes, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached image screenshot
No description provided.
Attachment #349949 - Flags: review?(faaborg)
Comment on attachment 349949 [details]
screenshot

looks great!
Attachment #349949 - Flags: review?(faaborg) → review+
Attached patch v1 (obsolete) — Splinter Review
This will apply after I land bug 450800 and will probably result in too narrow searchfields on Windows and Linux.
Attached patch v2Splinter Review
Attachment #351533 - Attachment is obsolete: true
Attachment #425780 - Flags: review?(dao)
Comment on attachment 425780 [details] [diff] [review]
v2

>+#filterRow > label
>+{

put this on one line for new rules
Attachment #425780 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/bf816d097a55
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Blocks: 547559
Depends on: 547974
I'm not really sure why the width of the search box was reduced.  Am I missing something?
Just because I thought it looked better when I experimented with the look a year ago and because that's what was ui-reviewed. I don't feel strongly about it, though. Faaborg, what do you think?
Looks good, perhaps make the search field a little wider in case the user types an entire variable name?  Making it stretch the entire width isn't good though, looks awkward and doesn't provide any additional value to the user.
Depends on: 558059
You need to log in before you can comment on or make changes to this bug.