466642 - Style about:config on OS X

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Markus Stange [:mstange]]

Attachment: screenshot

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 349949 [details]
screenshot

looks great!

Comment 2

[Markus Stange [:mstange]]

Attachment: v1

This will apply after I land bug 450800 and will probably result in too narrow searchfields on Windows and Linux.

Comment 3

[Markus Stange [:mstange]]

Attachment: dilate filter with radius="4 0"

(In reply to comment #5)
> |if (rx == 0 && ry == 0)| is wrong (it should be using ||

I don't think so. Right now, radius="4 0" gives a different result than radius="0", and that behavior makes sense to me.

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 370620 [details]
dilate filter with radius="4 0"

oops, wrong bug

Comment 5

[Markus Stange [:mstange]]

Attachment: v2

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 425780 [details] [diff] [review]
v2

>+#filterRow > label
>+{

put this on one line for new rules

Comment 7

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/bf816d097a55

Comment 8

[(no longer active)]

I'm not really sure why the width of the search box was reduced.  Am I missing something?

Comment 9

[Markus Stange [:mstange]]

Just because I thought it looked better when I experimented with the look a year ago and because that's what was ui-reviewed. I don't feel strongly about it, though. Faaborg, what do you think?

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

Looks good, perhaps make the search field a little wider in case the user types an entire variable name?  Making it stretch the entire width isn't good though, looks awkward and doesn't provide any additional value to the user.