46666 - customize Sidebar re-checks tabs that were unchecked (hidden)

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P1)

Description

[johng]

build 2000072508, win95

To reproduce:

- Add lots of tabs to My Sidebar.  Some of these tabs need to be added from the
Customize dialog that Netcenter hosts.  Also add one using a "Add tab" button on
a web site.
- Uncheck several tabs.  Make sure you uncheck some tabs that you added from the
customize dialog as well as tabs you added with the add tab button from another
site.  When you uncheck a tab, it is hidden and no longer visible within My
Sidebar (but remains on the list under "Add").
- Now add or delete any tab using the customize dialog (Add, Customize Sidebar,
add or remove tab).

Actual behavior:
- While the tabs are added or removed as you asked, many tabs that you did not
edit this time but were unchecked (hidden) before are now checked (visible).
- I noticed that all the tabs that I added from the customize dialog were the
ones that were auto-checked, but the one tab that I added via the javascript
button to "Add tab" was unchanged.

Correct behavoir:
- When you customize Sidebar by adding, removing or reording tabs, the checked/
unchecked status (visible/hidden) should not be changed.  New tabs that are
added should be checked (visible), but the current tabs should not have their
status changed.

Comment 1

[johng]

nsbeta3 nominee to review

Comment 2

[Claudius Gayle]

nav triage team: nsbeta3+
claudius: added url to a page with add Panel link.

Comment 3

[Steve Lamm]

I checked in a fix today.

Comment 4

[shrirang khanzode]

verified on all builds win/mac/linux(20000831m18)