466687 - NS_CP_GetDocShellFromContext semantics could be improved

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Dan Mosedale (:dmosedale, :dmose)]

NS_CP_GetDocShellFromContext can return a docshell that is often not the one that callers are likely to want.  We should consider if we can do better.  Quoting bz from bug 374577 comment 30:

What would be true is that specifically for TYPE_DOCUMENT
and TYPE_SUBDOCUMENT aContext either points to the frameElement of the window
the load is happening in (and in that case NS_CP_GetDocShellFromContext will
return the parent of the docshell the load is happening in), or points to the
window the load is happening in (and in that case NS_CP_GetDocShellFromContext
will return the docshell the load is happening in).  It's up to callers to QI
aContext and handle things accordingly if they want the docshell the load is
happening in.

It might also be worth a followup bug to decide whether this is the behavior
NS_CP_GetDocShellFromContext should have for DOCUMENT and SUBDOCUMENT.

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.