466765 - "ASSERTION: Bad race happening" (nsSpeculativeScriptThread::StartParsing)

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[Jesse Ruderman]

Attachment: stack trace (mac debug / gdb)

About 25% of the time, loading http://www.runnersworld.com/ triggers:

###!!! ASSERTION: Bad race happening: '!mCurrentlyParsing', file /Users/jruderman/central/parser/htmlparser/src/nsParser.cpp, line 411

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That sounds bad

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

The problem is that we were starting two speculative parsers that were then racing against each other. I'm assuming that we were near EOF when they were created, since otherwise, we probably would have crashed.

With this patch, the parser will only block itself once per recursive invocation.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/582e9452bc01

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b371f7c5be65

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED using the url provided by Jesse on debug builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.1pre) Gecko/20090706 Shiretoko/3.5.1pre ID:20090706143721

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090706 Minefield/3.6a1pre ID:20090706143743