Closed Bug 466784 Opened 16 years ago Closed 15 years ago

Port bug 462762 windows changes to the unix integration for new mail alerts.

Categories

(Thunderbird :: Mail Window Front End, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: eagle.lu, Assigned: mkmelin)

Details

Attachments

(2 files, 1 obsolete file)

31.59 KB, image/png
Details
1.85 KB, patch
standard8
: review+
standard8
: superreview+
Details | Diff | Splinter Review
Attached file screenshot (obsolete) —
re-produce steps
1. open a terminal
2. thunderbird -P 
   create a new profile
3. setup a Gmail IMAP account 
4. login 

expected result:
new mail alert window will popup and new mail info is shown in that window.

actual result
see the attached screenshot.
OS: Solaris → Linux
Attached image screenshot
Attachment #350132 - Attachment is obsolete: true
Is this meant to be the linux port of bug 462762?
Attached patch proposed fixSplinter Review
Port bug 462762 windows changes to the unix integration also.

(I also remove that comment, as there is no system tray icon on linux, yet.)
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #350213 - Flags: superreview?(bugzilla)
Attachment #350213 - Flags: review?(bugzilla)
(In reply to comment #3)
> Created an attachment (id=350213) [details]
> proposed 
> 
> Port bug 462762 windows changes to the unix integration also.
> 
> (I also remove that comment, as there is no system tray icon on linux, yet.)
Sorry, I verified the patch on the latest trunk code. The patch doesn't fix the bug.
Please see my comment at https://bugzilla.mozilla.org/show_bug.cgi?id=462762#c6
which is the root cause of this bug.
Attachment #350213 - Attachment description: proposed → proposed fix
Did you rebuild both in mailnews/base && mailnews/ ?

I haven't seen the broken alert more than very sporadically, so I can't verify if if fixes that case or not. However, it should fix whatever bug 462762 fixed.
(In reply to comment #5)
> Did you rebuild both in mailnews/base && mailnews/ ?
> 
Yes. I checked out the latest codes (2008/11/27), added the patch and then built 
TB from scratch.

> I haven't seen the broken alert more than very sporadically, so I can't verify
> if if fixes that case or not. However, it should fix whatever bug 462762 fixed.

It's very easy to verify:
1. Send several e-mails to your IMAP account to make sure there new unread e-mails
2. thunderbird -P 
   create a new profile
3. Select "Gmail IMAP"
4. Setup the account
5. Input the password to login

I think the patch doesn't fix the bug. The root cause is that 
  mFoldersWithNewMail is empty before alert window uses it.
Attachment #350213 - Flags: superreview?(bugzilla)
Attachment #350213 - Flags: superreview+
Attachment #350213 - Flags: review?(bugzilla)
Attachment #350213 - Flags: review+
Comment on attachment 350213 [details] [diff] [review]
proposed fix

I've not tested this, but I'm going to accept this on the basis that it should fix at least some problems with alerts - I think the specific case for this patch is as mentioned in bug 462762 comment 5:

"What was happening was that one server would get new mail, and notify, but
before the dialog got up, the second server would report no new mail, and clear
all biffs, ruining everybody's fun!"

Not sure if we should move this to a separate bug. From Boying's comments (and bug 462762 comment 14) it doesn't fix this bug by itself.
changeset:   1378:c72dc4ee9c6a
http://hg.mozilla.org/comm-central/rev/c72dc4ee9c6a

Sorry for stealing this Boying, I'm changing the summary to reflect what was done here. I see 462762 is now reopened, additional work there - or if we do another followup bug.

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Hardware: PC → All
Resolution: --- → FIXED
Summary: new mail alert window is broken after setting up a Gmail IMAP account → Port bug 462762 windows changes to the unix integration for new mail alerts.
Target Milestone: --- → Thunderbird 3.0b2
I just downloaded TB nightly build from ftp://ftp.mozilla.org/pub/thunderbird/nightly/2008/12/2008-12-28-03-comm-central/thunderbird-3.0b2pre.en-US.linux-i686.tar.bz2

The bug still exits.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This bug per it's summary is fixed - filed bug 471772 about the remaining
issue.
Status: REOPENED → RESOLVED
Closed: 16 years ago15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.