Option to refresh page periodically

RESOLVED FIXED

Status

Mozilla Labs
Prism
--
enhancement
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Matthew Gertner, Assigned: Matthew Gertner)

Tracking

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

10 years ago
Some sites (Facebook, Twitter, etc.) aren't properly ajaxy so you have to enable navigation and refresh manually, which is a pain. Would be nice to have an option in webapp.ini to refresh automatically every X seconds.
(Assignee)

Comment 1

10 years ago
Created attachment 350157 [details] [diff] [review]
No sooner said than done
Attachment #350157 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

10 years ago
Created attachment 350158 [details] [diff] [review]
And now the whole patch
Attachment #350157 - Attachment is obsolete: true
Attachment #350158 - Flags: review?(mark.finkle)
Attachment #350157 - Flags: review?(mark.finkle)
Attachment #350158 - Flags: review?(mark.finkle) → review+
Comment on attachment 350158 [details] [diff] [review]
And now the whole patch

We could add more error checking to the initial refresh check, instead of just null: negative #, strings

Also, what about the "Install App" dialog? We need to expose this property there too right? File a follow-up bug.
(Assignee)

Comment 4

10 years ago
Created attachment 352076 [details] [diff] [review]
Check value of refresh

How about this? Won't it check automatically whether the value can be converted to a number that is greater than zero? Or should I check for >= 1 to make sure it's not some tiny float value?
Attachment #350158 - Attachment is obsolete: true
Attachment #352076 - Flags: review?(mark.finkle)
(Assignee)

Comment 5

10 years ago
Comment on attachment 352076 [details] [diff] [review]
Check value of refresh

Ignore the prefs change. That's for another patch.
Comment on attachment 352076 [details] [diff] [review]
Check value of refresh

This is what I was thinking (without the "cmd_prefs" part)
Attachment #352076 - Flags: review?(mark.finkle) → review+
Although we still need a way to control/set this from the UI too, IMO

Install Dialog needs a way to set it and the Prefs page should allow changing it after the initial creation.
(Assignee)

Comment 8

10 years ago
Sending        common/modules/WebAppProperties.jsm
Sending        runtime/chrome/content/webrunner.js
Transmitting file data ..
Committed revision 20779.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.