Pointles contidion in Microformats.js:1631

NEW
Unassigned

Status

()

Firefox
General
--
trivial
9 years ago
8 years ago

People

(Reporter: Lukasz Stelmach, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; pl-PL; rv:1.9.0.3) Gecko/2008092814 Iceweasel/3.0.3 (Debian-3.0.3-3)
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; pl-PL; rv:1.9.0.3) Gecko/2008092814 Iceweasel/3.0.3 (Debian-3.0.3-3)

The if-else-if clause is pointless since s hasn't changed since 1609, the previous if-check. It is enough to leave the return statement alon.

Reproducible: Always

Comment 1

8 years ago
The line now is 1678 and you're right.

1678     if (s) {
1679       return s;
1680     } else {
1681       return this.latitude + ", " + this.longitude;
1682     }

should just be:

return this.latitude + ", " + this.longitude;
Status: UNCONFIRMED → NEW
Ever confirmed: true
You need to log in before you can comment on or make changes to this bug.