Closed Bug 466973 Opened 16 years ago Closed 9 months ago

Pointles contidion in Microformats.js:1631

Categories

(Firefox :: General, defect)

All
macOS
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: stlman, Unassigned)

References

()

Details

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; pl-PL; rv:1.9.0.3) Gecko/2008092814 Iceweasel/3.0.3 (Debian-3.0.3-3)
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; pl-PL; rv:1.9.0.3) Gecko/2008092814 Iceweasel/3.0.3 (Debian-3.0.3-3)

The if-else-if clause is pointless since s hasn't changed since 1609, the previous if-check. It is enough to leave the return statement alon.

Reproducible: Always
The line now is 1678 and you're right.

1678     if (s) {
1679       return s;
1680     } else {
1681       return this.latitude + ", " + this.longitude;
1682     }

should just be:

return this.latitude + ", " + this.longitude;
Status: UNCONFIRMED → NEW
Ever confirmed: true
Severity: trivial → S4

This code no longer exists

Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.