Closed
Bug 466990
Opened 16 years ago
Closed 16 years ago
options() in js shell silently ignore unknown option names
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
People
(Reporter: igor, Assigned: igor)
Details
Attachments
(1 file)
|
7.06 KB,
patch
|
crowderbt
:
review+
|
Details | Diff | Splinter Review |
Currently in js shell both -o option and the options() function ignore unknown option names. It would be nice if instead the shell would report an error message in such cases so misspelled names can be spotted immediately.
|
Assignee | |
Comment 1•16 years ago
|
||
With the patch the following happens with bad options:
~/m/31-ff/js/src> ./dbg/js -o jir
unknown option name 'jir'. The valid names are anonfunfix, atline, jit, relimit, strict, werror and xml.
~/m/31-ff/js/src> ./dbg/js -e 'options("jjit")'
-e:1: Error: unknown option name 'jjit'. The valid names are anonfunfix, atline, jit, relimit, strict, werror and xml.
Attachment #350331 -
Flags: review?(crowder)
|
||
Updated•16 years ago
|
Attachment #350331 -
Flags: review?(crowder) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
landed - http://hg.mozilla.org/mozilla-central/rev/bf71001d6521
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 3•16 years ago
|
||
this caught a typo in js1_5/Regress/regress-322430.js, landed http://hg.mozilla.org/mozilla-central/rev/36e81ad3e5f3 and cvs.
|
|
||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Flags: in-litmus-
|
|
||
Updated•16 years ago
|
Flags: in-testsuite+ → in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•