467038 - Get rid of nsWindow::DefaultWindowProc

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

I'ts no longer required since we've dropped AIMM support far past.
Now we could reliably determine whether our window is used for plug-in since bug 294688 was landed.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch v1.0.1

Sorry, we should call ::CallWindowProcW instead of ::DefWindowProcW.
Note that VC8 or later defines STRICT by default.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You can remove it from nsWindow.h too, right?

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: patch v1.0.2 [Checkin: Comment 6]

I've also changed ::LoadIcon().
> You can remove it from nsWindow.h too, right?
Sure.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Is LoadIconW available in Windows Mobile?

Comment 5

[Masatoshi Kimura [:emk]]

(In reply to comment #4)
> Is LoadIconW available in Windows Mobile?
I could build Fennec with this modification without any problems.
Windows Mobile suppots *only* LoadIconW. LoadIcon will be replaced with LoadIconW by preprocessor macro.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 350966 [details] [diff] [review]
patch v1.0.2
[Checkin: Comment 6]

http://hg.mozilla.org/mozilla-central/rev/3cc9cce7b7e7

Comment 7

[Ria Klaassen (not reading all bugmail)]

Is it on purpose that Minefield has no icon in the titlebars anymore?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Certainly not. Is there a bug filed?

Comment 9

[Ria Klaassen (not reading all bugmail)]

Missing titlebar icons filed as Bug 468419.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

If for some reason this patch needs to land on the 1.9.1 branch, the followup fix from bug 468419 should not be forgotten.