Closed Bug 467038 Opened 14 years ago Closed 14 years ago

Get rid of nsWindow::DefaultWindowProc

Categories

(Core :: Widget: Win32, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
I'ts no longer required since we've dropped AIMM support far past.
Now we could reliably determine whether our window is used for plug-in since bug 294688 was landed.
Attachment #350394 - Flags: superreview?(roc)
Attachment #350394 - Flags: review?(roc)
Attached patch patch v1.0.1 (obsolete) — Splinter Review
Sorry, we should call ::CallWindowProcW instead of ::DefWindowProcW.
Note that VC8 or later defines STRICT by default.
Attachment #350394 - Attachment is obsolete: true
Attachment #350396 - Flags: superreview?(roc)
Attachment #350396 - Flags: review?(roc)
Attachment #350394 - Flags: superreview?(roc)
Attachment #350394 - Flags: review?(roc)
You can remove it from nsWindow.h too, right?
I've also changed ::LoadIcon().
> You can remove it from nsWindow.h too, right?
Sure.
Assignee: nobody → VYV03354
Attachment #350396 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #350966 - Flags: superreview?(roc)
Attachment #350966 - Flags: review?(roc)
Attachment #350396 - Flags: superreview?(roc)
Attachment #350396 - Flags: review?(roc)
Is LoadIconW available in Windows Mobile?
(In reply to comment #4)
> Is LoadIconW available in Windows Mobile?
I could build Fennec with this modification without any problems.
Windows Mobile suppots *only* LoadIconW. LoadIcon will be replaced with LoadIconW by preprocessor macro.
Attachment #350966 - Flags: superreview?(roc)
Attachment #350966 - Flags: superreview+
Attachment #350966 - Flags: review?(roc)
Attachment #350966 - Flags: review+
Keywords: checkin-needed
Comment on attachment 350966 [details] [diff] [review]
patch v1.0.2
[Checkin: Comment 6]

http://hg.mozilla.org/mozilla-central/rev/3cc9cce7b7e7
Attachment #350966 - Attachment description: patch v1.0.2 → patch v1.0.2 [Checkin: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Is it on purpose that Minefield has no icon in the titlebars anymore?
Certainly not. Is there a bug filed?
Missing titlebar icons filed as Bug 468419.
If for some reason this patch needs to land on the 1.9.1 branch, the followup fix from bug 468419 should not be forgotten.
You need to log in before you can comment on or make changes to this bug.