467075 - Add additional listeners to common embedding APIs.

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: APIs, defect)

Description

[Tobias Hunger]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.4) Gecko/2008111616 Ubuntu/9.04 (jaunty) Firefox/3.0.4
Build Identifier: incubator/embedding hg repository rev. dabab67820e6

The (to be) attached patch adds new listeners for selection changes, editing events, console messages, etc. to the common API. These listeners are required to build a decent browser on top of the new embedding APIs.

The patch was tested with the Qt flavor of the new embedding APIs only and may depend on the patches found in reports #467071, #467072, #467073 and #467074.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Tobias Hunger]

Attachment: The actual patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Can you please attach a human-readable diff?

Comment 3

[Tobias Hunger]

Attachment: The actual patch (not gzip'ed)

Comment 4

[Tobias Hunger]

Sorry... I had assumed a gzip'ed diff would be ok and handled by the browsers. Seems like bugzilla gets the mimetype wrong, even though I set it explicitly:-(

Comment 5

[Boris Zbarsky [:bzbarsky]]

Bugzilla forces all attachments flagged as a patch to text/plain.

Comment 6

[Boris Zbarsky [:bzbarsky]]

I'm not sure whether the editing API we have right now is the frozen editing API we want to expose (complete with the currently-unfrozen nsITransactionManager, etc).  I can't quite tell whether the patch is basically exposing it directly or whether it's exposing a wrapper API that would allow us to improve the editor without breaking embeddings.

Comment 7

[Tobias Hunger]

Attachment: listeners patch v1.1

Incorporate feedback from reviewers.

Comment 8

[Tobias Hunger]

Is there anything I can do here?

Comment 9

[Tobias Hunger]

I am currently reworking this patch to be more decoupled.

So we can discuss issues like the editing API independent of the other code.

Comment 11

[Tobias Hunger]

Marked #467076 as a duplicate of this bug to document that both patches are getting merged.

Comment 12

[Benjamin Smedberg]

Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.