467085 - log4moz updateParents messed up, doesn't support multilevel parenting properly

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: fix, without unit tests

The parent detection code is overly optimistic in trying to find a parent, and finds itself in this._loggers, thus thinking that it has no parent closer to itself than root.

I've tested this manually and it works, and I'll also attach a unit test once I have the xulrunner SDK set up.

Comment 1

[Rain [:rain1] (inactive)]

Attachment: Updated patch to fix one more bug, and now with shiny new unit tests

One more bug fixed -- that really should hav been the other way round ;)

Unit tests now added, and they pass only with the patch applied.

thunder: are you the right person to ask for review?

Comment 2

[Dan Mills [:thunder]]

I am, and thanks!  I will review this today.

Comment 3

[Dan Mills [:thunder]]

Looks good on the surface, though I will give it a more careful read later today.

One nit: use the name getter for the loggers, instead of the _name 'private' property.

Comment 4

[Dan Mills [:thunder]]

Comment on attachment 350979 [details] [diff] [review]
Updated patch to fix one more bug, and now with shiny new unit tests

Great job on both bugs, and the tests.  Thanks!

Do you have commit access?

Comment 5

[Rain [:rain1] (inactive)]

Attachment: updated patch, nits fixed

Continuing r=thunder

Thanks for the review! No, I don't have commit access.

Comment 6

[Rain [:rain1] (inactive)]

Attachment: Bundle to checkin

Comment 7

[Daniel Brooks [:db48x]]

pushed