bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Update version of log4moz in gloda

RESOLVED FIXED in Thunderbird 3.0b2

Status

MailNews Core
Backend
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

Trunk
Thunderbird 3.0b2
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
There've apparently been a few bugfixes to log4moz that gloda should take.

This blocks bug 466732 because the fix for bug 467085 needs to be taken.
(Assignee)

Comment 1

10 years ago
Taking
Assignee: nobody → sid1337
(Assignee)

Comment 2

10 years ago
Created attachment 351535 [details] [diff] [review]
Patch, v1
[Checkin: Comment 8]

Updates log4moz. asuth, can you check if I got your downstream modifications in correctly?

One change that had to be made was that Log4Moz.Service had to be replaced with Log4Moz.repository. I did a global search and replace in mailnews/db/gloda.
Attachment #351535 - Flags: superreview?(bienvenu)
Attachment #351535 - Flags: review?(bugmail)
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED

Updated

10 years ago
Attachment #351535 - Flags: superreview?(bienvenu) → superreview+

Comment 3

10 years ago
Comment on attachment 351535 [details] [diff] [review]
Patch, v1
[Checkin: Comment 8]

some nits - a space before the ? here, and two other places:
+  this._formatter = formatter? formatter : new BasicFormatter();

missing newline at eof:
-}
\ No newline at end of file
+}
diff --git a/mailnews/db/gloda/modules/databind.js b/mailnews/db/gloda/modules/databind.js
(Assignee)

Comment 4

10 years ago
(In reply to comment #3)
> (From update of attachment 351535 [details] [diff] [review])
> some nits - a space before the ? here, and two other places:
> +  this._formatter = formatter? formatter : new BasicFormatter();
> 

Oh, this I directly got from upstream.

> missing newline at eof:
> -}
> \ No newline at end of file
> +}
> diff --git a/mailnews/db/gloda/modules/databind.js
> b/mailnews/db/gloda/modules/databind.js

The previous version of the file didn't have a new line, my editor automatically added one when it saved. ;)

Comment 5

10 years ago
oh, right re the line endings - and by upstream, you mean from the place where we took the log4moz code, so we want to stay in sync?
(Assignee)

Comment 6

10 years ago
(In reply to comment #5)
> and by upstream, you mean from the place where
> we took the log4moz code, so we want to stay in sync?

Yes, that'll be the weave repository, http://hg.mozilla.org/labs/weave/ .

I guess the less difference the better, as it becomes easier to later merge upstream fixes with asuth's downstream modifications.
Comment on attachment 351535 [details] [diff] [review]
Patch, v1
[Checkin: Comment 8]

Ideally we will not be maintaining downstream changes for long... I just don't think my existing downstream changes are what I want a week from now, so it doesn't make sense to drive them in as they exist.
Attachment #351535 - Flags: review?(bugmail) → review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Comment on attachment 351535 [details] [diff] [review]
Patch, v1
[Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/ba130c017ddd
Attachment #351535 - Attachment description: Patch, v1 → Patch, v1 [Checkin: Comment 8]
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
Target Milestone: mozilla1.9.1b3 → Thunderbird 3.0b2
Created attachment 351761 [details] [diff] [review]
"bustage" fix, glautocomp.js's use of log4moz got missed.

glautocomp's use of log4moz did not match the regex and we lacked a unit test to tell us that things broke... I will add one.
You need to log in before you can comment on or make changes to this bug.