467171 - Editing attachments doesn't update the Last-Modified timestamp

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[A. Shimono [:himorin]]

Attachment: patch v.1 (from a japanese user)

After editing attachments, Last-Modified in show_bug header isn't updated even if the bug-editing history is updated.

Comment 1

[A. Shimono [:himorin]]

Attachment: patch v.2

Sorry, forgot to modify the patch from the original. (to prevent executing un-necessary lines)

Comment 2

[Frédéric Buclin]

Comment on attachment 350593 [details] [diff] [review]
patch v.2

>+  my $ut_flag = 0;

What means "ut_flag"? $updated would be a much better name. Could you update your patch accordingly?


>+    my $ut = $dbh->prepare('UPDATE bugs SET delta_ts = ? WHERE bug_id = ?');
>+    $ut->execute($timestamp, $bug->id);

Please write a single ->do() call.

Comment 3

[Frédéric Buclin]

Is it a regression in 3.2, or has this bug been here forever?

Comment 4

[Max Kanat-Alexander]

No, I'm pretty sure this has always been the case, and we should investigate carefully to see if changing it will break anything.

Comment 5

[Frédéric Buclin]

Yeah, I checked in 2.22.6, and the bug was already there.

Comment 6

[A. Shimono [:himorin]]

(In reply to comment #2)
> (From update of attachment 350593 [details] [diff] [review])
> >+  my $ut_flag = 0;
> 
> What means "ut_flag"?

I don't know :-)
might be UpdaTe or Update_Txxxx? or something..

> $updated would be a much better name. Could you update your patch accordingly?

agree with this. > $updated

> >+    my $ut = $dbh->prepare('UPDATE bugs SET delta_ts = ? WHERE bug_id = ?');
> >+    $ut->execute($timestamp, $bug->id);
> 
> Please write a single ->do() call.

Ah, yeah. ->do() might be better.

I'll update the patch later.

(In reply to comment #4)
> No, I'm pretty sure this has always been the case, and we should investigate
> carefully to see if changing it will break anything.

As comment #5 and mxr, Last-Modified timestamp might be simply forgotten..

Comment 7

[A. Shimono [:himorin]]

Attachment: patch v.3

updated one.
# sorry for forgetting to attach :-)

Comment 8

[Frédéric Buclin]

Comment on attachment 350753 [details] [diff] [review]
patch v.3

This change makes sense. If you edit attachment flags, the bug timestamp is updated. If you comment while editing the attachment, the bug timestamp is updated. But if you edit another attachment attribute, the bug timestamp is not updated, which is inconsistent.

Note that this will now trigger bug mid-air collisions if you edit a bug at the same time an attachment is updated, now for all attribute changes, with which I'm fine (we are consistent). So r=LpSolit, for but tip only.

Comment 9

[Frédéric Buclin]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.150; previous revision: 1.149
done