Closed Bug 467172 Opened 11 years ago Closed 6 years ago

Document the space in event.freebusy.next.slot and event.freebusy.previous.slot

Categories

(Calendar :: General, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hendrik, Assigned: bv1578)

References

()

Details

Attachments

(1 file, 1 obsolete file)

There is a space at the end of event.freebusy.next.slot and at the start of event.freebusy.next.slot.

A little warning/explanation for localizers would be in order.
For example, I can imagine that in rtl languages, the spaces should be on the other end.
Attached patch patch - v1 (obsolete) — Splinter Review
I think this was only a temporary way to give a bit of margin between the labels and the icons in the buttons.
Deleted the spaces and added margins to the icons in the css file.
Attachment #8405293 - Flags: review?(Mozilla)
Assignee: nobody → bv1578
Status: NEW → ASSIGNED
Attached patch Patch - v2Splinter Review
Since I have changed the strings, I think I have to change the strings' name too.
Attachment #8405293 - Attachment is obsolete: true
Attachment #8405293 - Flags: review?(Mozilla)
Attachment #8411921 - Flags: review?(Mozilla)
Comment on attachment 8411921 [details] [diff] [review]
Patch - v2

Review of attachment 8411921 [details] [diff] [review]:
-----------------------------------------------------------------

works as expected.

r=markus
Attachment #8411921 - Flags: review?(Mozilla) → review+
Pushed to comm-central
https://hg.mozilla.org/comm-central/rev/c0d49e4668ce
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.4
You need to log in before you can comment on or make changes to this bug.