Closed
Bug 467172
Opened 16 years ago
Closed 10 years ago
Document the space in event.freebusy.next.slot and event.freebusy.previous.slot
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
3.4
People
(Reporter: hendrik, Assigned: bv1578)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
3.12 KB,
patch
|
Taraman
:
review+
|
Details | Diff | Splinter Review |
There is a space at the end of event.freebusy.next.slot and at the start of event.freebusy.next.slot. A little warning/explanation for localizers would be in order.
|
Reporter | |
Comment 1•16 years ago
|
||
For example, I can imagine that in rtl languages, the spaces should be on the other end.
I think this was only a temporary way to give a bit of margin between the labels and the icons in the buttons. Deleted the spaces and added margins to the icons in the css file.
Attachment #8405293 -
Flags: review?(Mozilla)
Since I have changed the strings, I think I have to change the strings' name too.
Attachment #8405293 -
Attachment is obsolete: true
Attachment #8405293 -
Flags: review?(Mozilla)
Attachment #8411921 -
Flags: review?(Mozilla)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8411921 [details] [diff] [review] Patch - v2 Review of attachment 8411921 [details] [diff] [review]: ----------------------------------------------------------------- works as expected. r=markus
Attachment #8411921 -
Flags: review?(Mozilla) → review+
Pushed to comm-central https://hg.mozilla.org/comm-central/rev/c0d49e4668ce
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.4
You need to log in
before you can comment on or make changes to this bug.
Description
•