Closed Bug 467207 Opened 16 years ago Closed 16 years ago

Remove MOZILLA_1_8_BRANCH ifdefs from Camino code

Categories

(Camino Graveyard :: General, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alqahira, Assigned: alqahira)

References

()

Details

Attachments

(1 file)

Now that the 1_8 branch is about to EOL, we really don't need the #if(n)defs on cvs trunk any more.

(I'm not sure of our spacing rules, or I'd do this myself.)
http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWrapper.mm

I think we want all the Gecko-related #include-s together, with no spacing within the Gecko-related group, so remove lines 64-67 and 69-70

http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWindowController.mm

Remove 2101-2104 (I don't think we care about the comment anymore since it's branch-only) and 2106.
Hardware: Macintosh → All
Does the deed, per cl's suggestions.  We can still block and unblock popups.
Assignee: nobody → alqahira
Status: NEW → ASSIGNED
Attachment #350706 - Flags: review?(cl-bugs-new)
Comment on attachment 350706 [details] [diff] [review]
1_8 branch ifdefectomy

Looks good here.
Attachment #350706 - Flags: superreview?(stuart.morgan+bugzilla)
Attachment #350706 - Flags: review?(cl-bugs-new)
Attachment #350706 - Flags: review+
Comment on attachment 350706 [details] [diff] [review]
1_8 branch ifdefectomy

sr=smorgan
Attachment #350706 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Landed on cvs trunk.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: