If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove MOZILLA_1_8_BRANCH ifdefs from Camino code

RESOLVED FIXED

Status

Camino Graveyard
General
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: Smokey Ardisson (offline for a while; not following bugs - do not email))

Tracking

Trunk
All
Mac OS X

Details

(URL)

Attachments

(1 attachment)

Now that the 1_8 branch is about to EOL, we really don't need the #if(n)defs on cvs trunk any more.

(I'm not sure of our spacing rules, or I'd do this myself.)

Comment 1

9 years ago
http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWrapper.mm

I think we want all the Gecko-related #include-s together, with no spacing within the Gecko-related group, so remove lines 64-67 and 69-70

http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWindowController.mm

Remove 2101-2104 (I don't think we care about the comment anymore since it's branch-only) and 2106.
Hardware: Macintosh → All
Created attachment 350706 [details] [diff] [review]
1_8 branch ifdefectomy

Does the deed, per cl's suggestions.  We can still block and unblock popups.
Assignee: nobody → alqahira
Status: NEW → ASSIGNED
Attachment #350706 - Flags: review?(cl-bugs-new)

Comment 3

9 years ago
Comment on attachment 350706 [details] [diff] [review]
1_8 branch ifdefectomy

Looks good here.
Attachment #350706 - Flags: superreview?(stuart.morgan+bugzilla)
Attachment #350706 - Flags: review?(cl-bugs-new)
Attachment #350706 - Flags: review+

Comment 4

9 years ago
Comment on attachment 350706 [details] [diff] [review]
1_8 branch ifdefectomy

sr=smorgan
Attachment #350706 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Landed on cvs trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.