Closed
Bug 467207
Opened 16 years ago
Closed 16 years ago
Remove MOZILLA_1_8_BRANCH ifdefs from Camino code
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: alqahira)
References
()
Details
Attachments
(1 file)
1.92 KB,
patch
|
bugzilla-graveyard
:
review+
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
Now that the 1_8 branch is about to EOL, we really don't need the #if(n)defs on cvs trunk any more. (I'm not sure of our spacing rules, or I'd do this myself.)
Comment 1•16 years ago
|
||
http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWrapper.mm I think we want all the Gecko-related #include-s together, with no spacing within the Gecko-related group, so remove lines 64-67 and 69-70 http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWindowController.mm Remove 2101-2104 (I don't think we care about the comment anymore since it's branch-only) and 2106.
Hardware: Macintosh → All
Assignee | ||
Comment 2•16 years ago
|
||
Does the deed, per cl's suggestions. We can still block and unblock popups.
Comment 3•16 years ago
|
||
Comment on attachment 350706 [details] [diff] [review] 1_8 branch ifdefectomy Looks good here.
Attachment #350706 -
Flags: superreview?(stuart.morgan+bugzilla)
Attachment #350706 -
Flags: review?(cl-bugs-new)
Attachment #350706 -
Flags: review+
Comment 4•16 years ago
|
||
Comment on attachment 350706 [details] [diff] [review] 1_8 branch ifdefectomy sr=smorgan
Attachment #350706 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Assignee | ||
Comment 5•16 years ago
|
||
Landed on cvs trunk.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•