46729 - “ or ” should paste (plaintext) as a normal quote instead of as a question mark

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Stuart Parmenter]

See http://bugzilla.mozilla.org/show_bug.cgi?id=38016 for earlier discussion of
this.  Basically we should convert smart quotes to normal quotes when pasting as
plain text before we convert to plain text so that we don't paste question
marks.

Comment 1

[nhottanscp]

There is an interface to do a charset conversion and transliteration,
see nsISaveAsCharset.idl. So the current charset conversion part can be replace 
by that.
Basically, call Init() first to specify fallback behavior for charset conversion 
failure then call convert().
For plain text, following flags can be specified for Init(). 
nsISaveAsCharset::attr_FallbackQuestionMark
nsISaveAsCharset::attr_EntityAfterCharsetConv
nsIEntityConverter::transliterate

Comment 2

[Peter Trudelle]

nsbeta3+

Comment 3

[Stuart Parmenter]

Attachment: patch... that doesn't work

Comment 4

[Stuart Parmenter]

i just attached a patch that does what you suggested... I still end up with ?s
instead of "s.  Any ideas?

Comment 5

[nhottanscp]

The patch looks fine. I applied the patch and I copied three characters – 
” and Ć. Then I was able to paste into 4.x as – ” C'.

Comment 6

[Stuart Parmenter]

right, I want both – and ” to end up as normal quotes.

Comment 7

[nhottanscp]

– is 0x2013 "EN DASH"
” is 0x201D "RIGHT DOUBLE QUOTATION MARK"
so the mapping is working correctly

“ is 0x201C "LEFT DOUBLE QUOTATION MARK"
I will change the summary.

Comment 8

[Stuart Parmenter]

oh, sorry.  so what must I do to convert the smart quotes to a normal quote
character?

Comment 9

[nhottanscp]

I think your patch already does that. 
But I realized that I cannot test that on NT since copy/paste is done by 
unicode.
Is that not working on Unix with your patch?

Comment 10

[Stuart Parmenter]

nope, they come out as ?s  :(

when I get in today, I will show you... maybe you can help me figure out what is
going on.

Comment 11

[nhottanscp]

I found that charset converter is putting question marks.
I filed a bug 48284. An encoder I am getting in nsISaveAsCharset is somehow 
cached and its state is affected by the fallback behavior set by someone else.
Since the encoder does it own fallback, nsISaveAsCharset does not have a chance 
to do its fallback (e.g. transliteration).

Comment 12

[nhottanscp]

I created a patch for bug 48284. With that patch, your patch works.
I was able to pasted “ and ” from 6.0 to 4.x without question marks.

Comment 13

[Stuart Parmenter]

fixed

Comment 14

[blanca]

verified fix - copy & paste works fine using 20001101