Closed Bug 467330 Opened 15 years ago Closed 15 years ago

shortcalendarweek and shortCalendarWeek used in the same file

Categories

(Calendar :: Calendar Frontend, defect)

Product:
Calendar
Component:
Calendar Frontend
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mschroeder, Assigned: hubert+bmo)

Details

Attachments

(1 file, 1 obsolete file)

Patch 0.2
3.77 KB, patch
berend.cornelius09
: review+
Details | Diff | Splinter Review 
From bug 401597 comment#18:
We have shortcalendarweek and shortCalendarWeek in the same file. Maybe one of
these keys should be changed to avoid confusion...

shortcalendarweek=CW
shortCalendarWeek=CW: %1$S
It was a bug 454933 comment#18
Assignee: nobody → hubert
Status: NEW → ASSIGNED
Attached patch Patch - proposal (obsolete) — — Splinter Review 

        Attachment #350833 -
        Flags: review?

    
  

        Attachment #350833 -
        Flags: review? → review?(mschroeder)

    
  

        Attachment #350833 -
        Flags: review?(mschroeder) → review?(Berend.Cornelius)

    
  

        Attachment #350833 -
        Flags: review?(Berend.Cornelius) → review+

    
    

    
  
Comment on attachment 350833 [details] [diff] [review]
Patch - proposal

patch is Ok. But it would be consequent to rename the resource "longCalendarWeek" also to "singleLongCalendarWeek".
r=berend

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch 0.2
        — 
          — Splinter Review
      

    


  
longCalendarWeek -> singleLongCalendarWeek

        Attachment #350833 -
        Attachment is obsolete: true

        Attachment #350995 -
        Flags: review?(Berend.Cornelius)

    
  

        Attachment #350995 -
        Flags: review?(Berend.Cornelius) → review+

    
    

    
  
Comment on attachment 350995 [details] [diff] [review]
Patch 0.2

patch looks good and works as advertised. I will push it to comm-central.

    
    

    
  
pushed to comm-central:

http://hg.mozilla.org/comm-central/rev/28399eb027cf

-> fixed.

Thank your for your effort
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0

    
    

    
  
Verified on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20081203 Calendar/1.0pre
Status: RESOLVED → VERIFIED
Target Milestone: 1.0 → 1.0b1

          You need to log in
          before you can comment on or make changes to this bug.