Commit button is not spaced the same vertically as the Status drop-down

VERIFIED FIXED in Bugzilla 3.2

Status

()

--
trivial
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: whimboo, Assigned: mkanat)

Tracking

Bugzilla 3.2
Bug Flags:
approval +
approval3.2 +

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
With the latest changes on bug 466912 the commit button is now placed under the comment text area. But it's top padding is a bit too small. It should have the same distance to the comment text area as the status drop down fields on the left side. See also the latest comments on bug 466912 comment 15.

With this fix bug 466912 will be completely solved I think.
(Reporter)

Updated

10 years ago
Duplicate of this bug: 467335
See also screenshot attachment 350747 [details]. IMHO it's the Commit button which is too near the textarea border.

Updated

10 years ago
No longer blocks: 466912
Depends on: 466912

Updated

10 years ago
Severity: normal → trivial
Version: unspecified → 3.2
(Assignee)

Comment 3

10 years ago
Bug summaries should always describe the problem, not your suggested solution.
Summary: Commit button should have the same top padding as the status drop downs → Commit button is not spaced the same vertically as the Status drop-down
(Assignee)

Comment 4

10 years ago
Created attachment 350861 [details] [diff] [review]
v1

This fixes the problem.

I'd also like to point out, for the future, that I already mentioned this fix and that it would have taken less time to post this patch than to collect a screenshot and two bugs on the subject.
Assignee: ui → mkanat
Status: NEW → ASSIGNED
Attachment #350861 - Flags: review?(guy.pyrzak)
(Assignee)

Updated

10 years ago
Target Milestone: --- → Bugzilla 3.2
(In reply to comment #4)
> Created an attachment (id=350861) [details]
> v1
> 
> This fixes the problem.
> 
> I'd also like to point out, for the future, that I already mentioned this fix
> and that it would have taken less time to post this patch than to collect a
> screenshot and two bugs on the subject.

OK, so I overreacted; next time I won't, or not as fast. You still told Henrik "but we could fix it if you file another bug" in bug 466912 comment #15.
(Assignee)

Comment 6

10 years ago
(In reply to comment #5)
> OK, so I overreacted; next time I won't, or not as fast. You still told Henrik
> "but we could fix it if you file another bug" in bug 466912 comment #15.

  No, you're right. I was a little cranky when I wrote that. :-) But (as a general commentary on development, not about you guys) I do think that sometimes it's kind of funny the effort people spend on talking about something when they could be fixing it.
In reply to comment #6: :-)

Who again (some Greek or maybe Chinese philosopher I think) said the following? "Those who know, do. Those who don't know, teach".

Comment 8

10 years ago
Comment on attachment 350861 [details] [diff] [review]
v1

>-          <table class="status">
>+          <table class="status" cellspacing="0" cellpadding="0">

With this fix, there is no space left between the status field and the comment box. I would rather do the opposite.
(Assignee)

Comment 9

10 years ago
(In reply to comment #8)
> With this fix, there is no space left between the status field and the comment
> box. I would rather do the opposite.

  No, there's some space, about a pixel's worth.

Comment 10

10 years ago
Comment on attachment 350861 [details] [diff] [review]
v1

This accomplishes what the bug requests, but I'd rather see the spacing fixed instead of removed. But I can file another bug to add more spacing between the comment and the status drop down.
Attachment #350861 - Flags: review?(guy.pyrzak) → review+
(Assignee)

Updated

10 years ago
Flags: approval3.2+
Flags: approval+
(Assignee)

Comment 11

10 years ago
tip:

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.147; previous revision: 1.146
done

3.2:

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.125.2.18; previous revision: 1.125.2.17
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Reporter)

Comment 12

10 years ago
Verified with the bugzilla upgrade yesterday.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.