Closed Bug 467383 Opened 16 years ago Closed 16 years ago

Reduce QIs and AddRef/Releases caused by nsContentUtils::HasMutationListeners

Categories

(Core :: DOM: Events, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(2 files, 1 obsolete file)

I used this artificial testcase to profile changing attribute value.
nsGlobalWindow::QI and AddRef/Release shows up in the profile, taking 2-3%.

Patch coming once I've run all the tests.
Attached patch proposed patch (obsolete) — Splinter Review
This should keep the current behavior, but reduce needed QIs whenever
nsDocument has mWindow (and it usually does have it).
Attachment #350800 - Flags: superreview?(jonas)
Attachment #350800 - Flags: review?(jonas)
Attachment #350800 - Attachment is obsolete: true
Attachment #350800 - Flags: superreview?(jonas)
Attachment #350800 - Flags: review?(jonas)
Attached patch this oneSplinter Review
This one shouldn't change the behavior at all.
Attachment #350807 - Flags: superreview?(jonas)
Attachment #350807 - Flags: review?(jonas)
Attachment #350807 - Flags: superreview?(jonas)
Attachment #350807 - Flags: superreview+
Attachment #350807 - Flags: review?(jonas)
Attachment #350807 - Flags: review+
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: