Closed Bug 467386 Opened 16 years ago Closed 16 years ago

change default branding on mozilla-1.9.1

Categories

(Firefox Build System :: General, defect)

3.5 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla3.1b3

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file)

mozilla-1.9.1 builds should get "Shiretoko" branding by default. In the past, we've simply changed the nightly build machine configs, but we really should change the default so that everyone building from that branch gets the right branding by default.

I've tried just adding:
MOZ_BRANDING_DIR=browser/branding/unofficial
to browser/confvars.sh, but that didn't seem to work.

(See also bug 455395, the equivalent for CVS trunk.)
Attached patch patchSplinter Review
This needs a clobber to take full effect, otherwise brand.dtd doesn't get updated.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #350816 - Flags: review?
Attachment #350816 - Flags: review? → review+
https://hg.mozilla.org/releases/mozilla-1.9.1/rev/04eb06993202
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b3
Looks good using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20081216 Shiretoko/3.1b3pre. Will verify on Mac and Linux next.
Keywords: verified1.9.1
sorry for the inconvenience.  i meant to detect any bugs before the branch merge that were still RESO fixed, but had a verified1.9.1 keyword next to them.
Keywords: verified1.9.1
Component: Build Config → General
Product: Firefox → Firefox Build System
Keywords: verified1.9.1
Target Milestone: Firefox 3.1b3 → mozilla3.1b3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: