If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

EM tests are touching the network

VERIFIED FIXED in mozilla1.9.1b3

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

({verified1.9.0.5, verified1.9.1})

Trunk
mozilla1.9.1b3
verified1.9.0.5, verified1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 350862 [details] [diff] [review]
patch rev 1

A couple of EM tests are still pinging AMO for update information. AMO returns no information but if it takes too long then the tests could timeout. This patch removes all instances I can see.
(Assignee)

Updated

9 years ago
Attachment #350862 - Flags: review?(robert.bugzilla)
(Assignee)

Comment 1

9 years ago
Created attachment 350864 [details] [diff] [review]
patch rev 2

I guess we should actually create a test server when there isn't one too.
Assignee: nobody → dtownsend
Attachment #350862 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #350864 - Flags: review?(robert.bugzilla)
Attachment #350862 - Flags: review?(robert.bugzilla)
Attachment #350864 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 2

9 years ago
Landed in mozilla-central: http://hg.mozilla.org/mozilla-central/rev/8170fbbdb426
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
(Assignee)

Comment 3

9 years ago
Landed in mozilla-1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4f77c6ce0ca8
Keywords: fixed1.9.1

Comment 4

9 years ago
anything i can physically verify here?  if not, can i assume the testserver.start() case is good enough?
Keywords: fixed1.9.1
(Assignee)

Comment 5

9 years ago
No this is just an amendment to the automated tests. Was removing fixed-1.9.1 intentional?

Comment 6

9 years ago
(In reply to comment #5)
> No this is just an amendment to the automated tests. Was removing fixed-1.9.1
> intentional?

I think i mid-air'ed with you.  Sorry, restoring keyword.
Keywords: fixed1.9.1
(Assignee)

Comment 7

9 years ago
Also landed on 3.0 branch.
Keywords: fixed1.9.0.5
Verified for 1.9.0.5 since the tests are passing there.
Keywords: fixed1.9.0.5 → verified1.9.0.5

Comment 9

9 years ago
Verified Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090212 Minefield/3.2a1pre 
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090212 Shiretoko/3.1b3pre Ubiquity/0.1.5
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.