Closed Bug 467438 Opened 13 years ago Closed 13 years ago

EM tests are touching the network

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9.1b3

People

(Reporter: mossop, Assigned: mossop)

Details

(Keywords: verified1.9.0.5, verified1.9.1)

Attachments

(1 file, 1 obsolete file)

Attached patch patch rev 1 (obsolete) — Splinter Review
A couple of EM tests are still pinging AMO for update information. AMO returns no information but if it takes too long then the tests could timeout. This patch removes all instances I can see.
Attachment #350862 - Flags: review?(robert.bugzilla)
Attached patch patch rev 2Splinter Review
I guess we should actually create a test server when there isn't one too.
Assignee: nobody → dtownsend
Attachment #350862 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #350864 - Flags: review?(robert.bugzilla)
Attachment #350862 - Flags: review?(robert.bugzilla)
Attachment #350864 - Flags: review?(robert.bugzilla) → review+
Landed in mozilla-central: http://hg.mozilla.org/mozilla-central/rev/8170fbbdb426
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
anything i can physically verify here?  if not, can i assume the testserver.start() case is good enough?
Keywords: fixed1.9.1
No this is just an amendment to the automated tests. Was removing fixed-1.9.1 intentional?
(In reply to comment #5)
> No this is just an amendment to the automated tests. Was removing fixed-1.9.1
> intentional?

I think i mid-air'ed with you.  Sorry, restoring keyword.
Keywords: fixed1.9.1
Also landed on 3.0 branch.
Keywords: fixed1.9.0.5
Verified for 1.9.0.5 since the tests are passing there.
Verified Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090212 Minefield/3.2a1pre 
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090212 Shiretoko/3.1b3pre Ubiquity/0.1.5
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.