Closed
Bug 46749
Opened 24 years ago
Closed 24 years ago
crash clicking menu on personal toolbar
Categories
(SeaMonkey :: General, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: dbaron, Assigned: asa)
Details
In an optimized non-debug Linux build from the trunk at 18:20 PDT today, I crash if I click any button in the personal toolbar that is a menu (this includes the "Bookmarks" menu on the personal toolbar). I did not see this in my build this morning. #0 0x40f0e6aa in nsMenuFrame::OpenMenuInternal () #1 0x40f0e43a in nsMenuFrame::AttributeChanged () #2 0x40e6d74d in nsCSSFrameConstructor::AttributeChanged () #3 0x40f64da9 in StyleSetImpl::AttributeChanged () #4 0x40d6d8eb in PresShell::AttributeChanged () #5 0x405320b6 in nsXULDocument::AttributeChanged () #6 0x40522891 in nsXULElement::SetAttribute () #7 0x4051f03f in nsXULElement::SetAttribute () #8 0x40f0e564 in nsMenuFrame::OpenMenu () #9 0x40f0df6e in nsMenuFrame::ToggleMenuState () #10 0x40f0daf0 in nsMenuFrame::HandleEvent () #11 0x40d6e5f2 in PresShell::HandleEventInternal () #12 0x40d6e42c in PresShell::HandleEvent ()
Reporter | ||
Comment 1•24 years ago
|
||
This looks like it's pinkerton's checkin.
Reporter | ||
Comment 2•24 years ago
|
||
I'm guessing this might do it: Index: nsMenuFrame.cpp =================================================================== RCS file: /cvsroot/mozilla/layout/xul/base/src/nsMenuFrame.cpp,v retrieving revision 1.141 diff -u -d -r1.141 nsMenuFrame.cpp --- nsMenuFrame.cpp 2000/07/28 00:25:18 1.141 +++ nsMenuFrame.cpp 2000/07/28 03:57:28 @@ -586,7 +586,8 @@ if (menuPopup) { // inherit whether or not we're a context menu from the parent PRBool parentIsContextMenu = PR_FALSE; - mMenuParent->GetIsContextMenu(parentIsContextMenu); + if (mMenuParent) + mMenuParent->GetIsContextMenu(parentIsContextMenu); menuPopup->SetIsContextMenu(parentIsContextMenu); // Install a keyboard navigation listener if we're the root of the menu chain.
Comment 3•24 years ago
|
||
fix in hand, stupid stupid stupid.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•24 years ago
|
||
Marking verified since pinkerton put in a null check around the line that was crashing (and a few others).
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•