467506 - -d $dir check in add_language_set should not be commented-out

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Max Kanat-Alexander]

Attachment: v1

Apparently when I wrote Bugzilla::Install::Util::_add_language_set, I commented-out a check that makes sure that a directory actually *exists* before pushing it onto the template include path stack. I probably did this for testing purposes, to make sure that the directories all existed in the right order, but I forgot to uncomment the check before the code was checked in.

In any case, I'm sure that it's much better to do this check just once at this point as opposed to every time we load a template or string. Also, "-d $dir" is the reason that it's safe to do our trick_taint--otherwise we could be getting something unexpected out of the filesystem (though there are no security implications to this bug, as far as I'm aware).

Comment 1

[Frédéric Buclin]

Comment on attachment 350932 [details] [diff] [review]
v1

Yes, makes sense to me. r=LpSolit

Comment 2

[Max Kanat-Alexander]

tip:

Checking in Bugzilla/Install/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Util.pm,v  <--  Util.pm
new revision: 1.16; previous revision: 1.15
done

3.2:

Checking in Bugzilla/Install/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Util.pm,v  <--  Util.pm
new revision: 1.14.2.2; previous revision: 1.14.2.1
done