Closed
Bug 467551
Opened 17 years ago
Closed 17 years ago
Bugzilla should have debug option for all mail, not only for smtp
Categories
(Bugzilla :: Email Notifications, enhancement)
Bugzilla
Email Notifications
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: michael.j.tosh, Unassigned)
Details
Attachments
(1 file)
|
486 bytes,
patch
|
mkanat
:
review-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Build Identifier: Bugzilla 3.0
A logging mechanism for other mailer types should be included. I suggest a simple print to STDERR in the Bugzilla/Mailer.pm file.
This would not capture all the details of Sendmail and the sort, but would at least be able to capture a subject line, time, and recepient.
Here: http://mxr.mozilla.org/mozilla/source/webtools/bugzilla/Bugzilla/Mailer.pm#177
Insert the following code at the end of the MessageToMTA function:
+ print STDERR "Emailing '" . $email->header('Subject') .
+ "' to " . $email->header('To') . "\n"
+ if Bugzilla->params->{'smtp_debug'};
Reproducible: Always
another string piece may be:
" via " . $method
where $method is SMTP or Sendmail or Test
Comment 2•17 years ago
|
||
Did you actually encounter a need for this?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Yes. We get complaints monthly that an email was never received. Since we use Sendmail, and are not the sendmail admins, we have no way of knowing if/when the email was sent.
Max, here is a simple patch that will write to STDERR (Apache Error Log) with a single line when smtp_debug is turned on, no matter what the MTA.
Do you think the name of the param needs to be changed too? I don't really think so myself.
Attachment #357345 -
Flags: review?(mkanat)
Comment 5•17 years ago
|
||
Don't request approval before we have a reviewed patch.
Flags: approval?
Flags: approval3.2?
Comment 6•17 years ago
|
||
Comment on attachment 357345 [details] [diff] [review]
Code Patch Ver 1
Yeah, I don't want this. This is what Test mailing mode is for. Also, all reasonable SMTP clients have logs.
Attachment #357345 -
Flags: review?(mkanat) → review-
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•