Closed Bug 467618 Opened 16 years ago Closed 16 years ago

Remove tabbbrowser-tab binding in tabbrowser.xml

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a3

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(1 file, 2 obsolete files)

mac classic's tabbrowser.css don't need the binding anymore now when bug 467091 is fixed.
Attached patch Remove binding (obsolete) — Splinter Review
I need to test this a bit more before I ask for review.
Attached patch Patch for real (obsolete) — Splinter Review
Oops, I had other changes in there too...
Attachment #351025 - Attachment is obsolete: true
JFTR, I added the tabbrowser-tab binding in bug 376912.
Attachment #351028 - Flags: review?(neil)
Attachment #351028 - Flags: review?(mnyromyr)
Comment on attachment 351028 [details] [diff] [review]
Patch for real

I figured Karsten could verify mac.
Status: NEW → ASSIGNED
Target Milestone: --- → seamonkey2.0a3
Attachment #351028 - Flags: review?(neil)
Attachment #351028 - Flags: review?(mnyromyr)
Comment on attachment 351028 [details] [diff] [review]
Patch for real

In fact, I might not need the centering since it turns out that I can probably do some cleanup in bug 467294. Better wait until that one is finished ;-)
Comment on attachment 351028 [details] [diff] [review]
Patch for real

> .tabbrowser-tabs > .tabbrowser-tab {
>-  -moz-binding: url("chrome://navigator/content/tabbrowser.xml#tabbrowser-tab");
>+  -moz-binding: url("chrome://global/content/bindings/tabbox.xml#tab");
> }
You can probably eliminate this entire rule, as that's the default anyway.
(In reply to comment #6)
> (From update of attachment 351028 [details] [diff] [review])
> > .tabbrowser-tabs > .tabbrowser-tab {
> >-  -moz-binding: url("chrome://navigator/content/tabbrowser.xml#tabbrowser-tab");
> >+  -moz-binding: url("chrome://global/content/bindings/tabbox.xml#tab");
> > }
> You can probably eliminate this entire rule, as that's the default anyway.

Yes, will do. I'll try and get the patch in bug 467294 landed on 1.9.1. Then I'll attach an updated patch.
Attached patch New versionSplinter Review
Doing what Neil suggests in comment #6 and there's no need for .tab-middle to have "-moz-boz-align: center;" now when bug 467294 has landed on 1.9.1.
Attachment #351028 - Attachment is obsolete: true
Attachment #352125 - Flags: review?(neil)
Attachment #352125 - Flags: review?(mnyromyr)
Comment on attachment 352125 [details] [diff] [review]
New version

sr=me
Attachment #352125 - Flags: review?(neil) → review+
Comment on attachment 352125 [details] [diff] [review]
New version

With this patch, the tab icons get squeezed horizontally; very visible e.g. on seamonkey-project.org.
Attachment #352125 - Flags: review?(mnyromyr) → review-
(In reply to comment #10)
> (From update of attachment 352125 [details] [diff] [review])
> With this patch, the tab icons get squeezed horizontally; very visible e.g. on
> seamonkey-project.org.

Mac classic? I suspect you haven't updated your tree... See bug 467294.
Comment on attachment 352125 [details] [diff] [review]
New version

D'oh - possibly... :-|
Attachment #352125 - Flags: review- → review?(mnyromyr)
If you by squeezed mean that they're stretched they shouldn't be that with a updated 1.9.1 tree. The old code had -moz-box-align: stretch; in tabbox.css, but now we're relying on the centering in xul.css.
Comment on attachment 352125 [details] [diff] [review]
New version

> I suspect you haven't updated your tree.

So it seems. :-|
Attachment #352125 - Flags: review?(mnyromyr) → review+
Pushed changeset 74163a6a6316 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.