467649 - The l10n scheduler's name when declaring DependentL10n is incorrect

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Armen [:armenzg]]

Attachment: fixes the name given to a DependentL10n scheduler

There are discrepancies between what gets added to l10nNightlyBuilder, the patch fixes this:

Old code:
 c['schedulers'].append(DependentL10n(
     name='%s l10n' % sched,
New code:
 c['schedulers'].append(DependentL10n(
     name=l10nNightlyBuilders[i],

By using this in master.cfg:
 log.msg(l10nNightlyBuilders[i])
 log.msg(sched + 'l10n') #This is the same as '%s l10n' % sched
I would get this in twistd.log:
 Linux mozilla-central l10n nightly
 Linux mozilla-central nightly l10n

Comment 1

[Chris Cooper [:coop] (he/him)]

Comment on attachment 351069 [details] [diff] [review]
fixes the name given to a DependentL10n scheduler

changeset:   580:087a643f7707

Comment 2

[Chris Cooper [:coop] (he/him)]

The first set of dependent l10n builds trigger correctly after a mozilla-central en-US nightly, but subsequent nightlies do not seem to trigger the dependent scheduler.

Armen has posited that there may be a discrepancy between the builder names between various parts of the scheduling process:

http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla2/master.cfg#l74
http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla2/master.cfg#l168

Comment 3

[Chris Cooper [:coop] (he/him)]

A master restart seems to have resolved this.