If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Embedding readme.html is not XHTML compliant, or cleanly written

VERIFIED WONTFIX

Status

Core Graveyard
Embedding: ActiveX Wrapper
--
minor
VERIFIED WONTFIX
9 years ago
6 years ago

People

(Reporter: Tyler, Assigned: Tyler)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

9 years ago
This is not a bug deal, but I have upgraded this file to XHTML 1.0, and have cleaned up the code.
(Assignee)

Comment 1

9 years ago
Created attachment 351102 [details] [diff] [review]
Patch v1

This simply makes compliant with XHTML 1 strict, with a few minor code cleanups.
Attachment #351102 - Flags: review?(brendan)
(Assignee)

Updated

9 years ago
Attachment #351102 - Flags: review?(brendan) → review?(jst)
(Assignee)

Updated

9 years ago
Summary: readme.html is not XHTML compliant → Embedding readme.html is not XHTML compliant
(Assignee)

Comment 2

9 years ago
I changed the review request to jst because I saw he works more with this module. No slight to Brendan :).
Tyler, any chance we could keep the old formatting for readability of the HTML here, just add the missing tags etc to make it compliant? That would also make the diff significantly easier to read...
(Assignee)

Comment 4

9 years ago
If you simply want it compliant, I can do that too.
(Assignee)

Comment 5

9 years ago
Sorry, I did not read your comment properly. I actually did not change the readability much (except for on h2, I moved to an h1). The <i> and <b> tags are not recommended for use anymore, so I replaced them with <em> and <strong>, which look the same, but look the same by default. I also removed a bit of whitespace, old unused tags, and cleaned it up a bit. I will attach a file that shows how it looks, to make looking at the diff easier.
Summary: Embedding readme.html is not XHTML compliant → Embedding readme.html is not XHTML compliant, or cleanly written
(Assignee)

Comment 6

9 years ago
Created attachment 353709 [details]
How this patch looks when applied

This is what the patch changes (almost nothing).
(Assignee)

Comment 7

9 years ago
It actually seems to make even more sense to totally remove this entire document, and place it on a mozilla.org site (like devmo). Bug 471215 is on that. Added all you to the CC on that bug as well.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

9 years ago
Status: RESOLVED → VERIFIED

Updated

8 years ago
Attachment #351102 - Flags: review?(jst)
Component: Embedding: ActiveX Wrapper → Embedding: ActiveX Wrapper
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.