Remove warnings from nanojit code on MSVC

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 351216 [details] [diff] [review]
Patch

the Nativei386 code macros in nanojit rely on warning 4310 being disabled in MSVC, but this is done in the vcproject file rather than the source, so projects using alternate project structures fail. Patch moves the warning-disable into the source files rather than the project file (and re-enables the warning in the nanojit project).
Attachment #351216 - Flags: review?(rreitmai)

Comment 1

10 years ago
Comment on attachment 351216 [details] [diff] [review]
Patch

Did you intend to remove all other warnings from the project file.  

If it all still builds that would be good.
Attachment #351216 - Flags: review?(rreitmai) → review+
(Assignee)

Comment 2

10 years ago
Yep, no warnings.
(Assignee)

Comment 3

10 years ago
pushed to redux as changeset:   1186:4110bde0656f
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 4

9 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.