Closed Bug 467825 Opened 11 years ago Closed 11 years ago

Add a tool to the xulrunner SDK to add icon and VERSIONINFO to xulrunner-stub on Windows

Categories

(Toolkit Graveyard :: XULRunner, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Dave Townsend started a simple tool, used in McCoy and XULExplorer, to add a custom icon to the xulrunner-stub during the build process. Extending this idea to include VERSIONINFO would be even better.

http://viewvc.svn.mozilla.org/vc/projects/mccoy/trunk/tools/redit/
I'm working on equivalent stuff for Songbird based off redit, and can be upstreamed.  We're thinking of making it read a .ini file for the parameters (executable name and ini file name to be passed in on command line), does that sound alright?

(Currently, it reads in the version info table, sorts them as a side effect of putting things in a std::map, and writes them back out so I can check that I didn't screw up)
Blocks: 474813
Attached patch patchSplinter Review
Attachment #358334 - Flags: review?(benjamin)
Comment on attachment 358334 [details] [diff] [review]
patch

This patch adds a simple resource tool that will put a given ICO into a given EXE/DLL file.

I added the code to xulrunner/tools/redit and the Makefile.in is ready to work on WINCE and WINNT platforms. The resulting redit.exe is placed into the xulrunner/dist/sdk/bin folder.
Attachment #358334 - Flags: review?(benjamin) → review+
There is more we can add to this tool, but I'd like to get it landed as is for now.
pushed http://hg.mozilla.org/mozilla-central/rev/cdfb8740793d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 358334 [details] [diff] [review]
patch

We'll need this patch on 1.9.1 as well. It's NPOTB there too.
Attachment #358334 - Flags: approval1.9.1?
Attachment #358334 - Flags: approval1.9.1? → approval1.9.1+
Assignee: nobody → mark.finkle
Whiteboard: [needs 1.9.1 landing]
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.