Closed Bug 467854 Opened 15 years ago Closed 15 years ago

TM: Freezes with jit.content enabled [@ nanojit::Assembler::asm_store32]

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dvander, Assigned: dvander)

References

(
URL
)

Details

(Keywords: fixed1.9.1, hang, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

proposed fix
590 bytes, patch
gal
: review+
Details | Diff | Splinter Review 
We get a slow script dialog on this site because assembler errors don't blacklist, so we keep trying to compile a long trace that fails every time.
Attached patch proposed fix — — Splinter Review 
Assignee: general → danderson
Status: NEW → ASSIGNED

        Attachment #351290 -
        Flags: review?(gal)

    
    

    
  
Whats the cause of the assembler error? If we just accidentally run out of memory I am not sure we want to blacklist.

    
    

    
  
This is from bug 460511 where the reservation table gets filled.

    
  

        Attachment #351290 -
        Flags: review?(gal) → review+

    
    

    
  
Pushed fix as changeset: http://hg.mozilla.org/tracemonkey/rev/68a4eb0bcf48

Requesting blocking flag since this is really an unpleasant bug.
Severity: enhancement → normal
Flags: blocking1.9.1?
Whiteboard: fixed-in-tracemonkey

    
  
Flags: blocking1.9.1? → blocking1.9.1+

    
  
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-

          You need to log in
          before you can comment on or make changes to this bug.