467856 - Expose SQLITE_IOERR

Status: VERIFIED FIXED

(Toolkit :: Storage, defect, P1)

Description

[Marco Bonardo [:mak]]

if an sqlite database is in use by another application opening the connection could return SQLITE_IOERR instead of SQLITE_LOCKED.

Notice this sqlite 3 doc about extended result codes
http://www.sqlite.org/c3ref/c_ioerr_access.html

and notice that:
#define SQLITE_LOCKED       6   /* A table in the database is locked */
(from http://www.sqlite.org/c3ref/c_abort.html)

so we are practically using TABLE_IS_LOCKED as FILE_IS_LOCKED error, while we should detect SQLITE_IOERR_UNLOCK, SQLITE_IOERR_RDLOCK, SQLITE_IOERR_LOCK to correctly detect if a file is locked.

if we can't make mozStorage use extended result codes, we should at least provide a generic NS_ERROR_STORAGE_IOERROR

Comment 1

[Marco Bonardo [:mak]]

per IRC we can't expose extended results code per compatibility issues (will be done for moz2) so for now we only expose SQLITE_IOERR

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 351295 [details] [diff] [review]
patch

>+#define NS_ERROR_STORAGE_IOERR \
>+  NS_ERROR_GENERATE_FAILURE(NS_ERROR_MODULE_STORAGE, SQLITE_IOERR)
I had to fix bustage with this yesterday - just make this 2

r=sdwilsh

Comment 4

[Marco Bonardo [:mak]]

asking blocking because is blocking places from detecting database status

Comment 5

[Dietrich Ayala (:dietrich)]

blocking+.

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch v1.1

unbitrot and fixed comment

Comment 7

[Marco Bonardo [:mak]]

pushed to trunk
http://hg.mozilla.org/mozilla-central/rev/bad1a35faa15

Comment 8

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/61050a8edfed