cairo calls FT_Done_Face on FT_Faces for unscaled_fonts created from_face
RESOLVED
FIXED
in mozilla1.9.1b3
Status
()
People
(Reporter: karlt, Assigned: karlt)
Tracking
({fixed1.9.1})
Firefox Tracking Flags
(Not tracked)
Details
(URL)
Attachments
(1 attachment)
|
2.21 KB,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
This would cause random crashes in FT_Done_Face or FT_Set_Transform after browsing pages with @font-face { src: url() } when bug 458169 is landed, so we'll want the fix landed before an upstream fix and moz cairo upgrade.Flags: blocking1.9.1?
|
(Assignee) | |
Comment 1•9 years ago
|
||
Created attachment 351320 [details] [diff] [review] patch for moz cairo [pushed to m-c][pushed to 1.9.1]
Do you want to request review here? Vlad if no-one else springs to mind.
|
|
(Assignee) | |
Comment 3•9 years ago
|
||
Comment on attachment 351320 [details] [diff] [review] patch for moz cairo [pushed to m-c][pushed to 1.9.1] Behdad, this is the same patch as on the freedesktop bug. Do you see any problem with doing this?
Attachment #351320 -
Flags: review?(mozilla)
|
||
Comment 4•9 years ago
|
||
The patch looks correct. I was going to commit upstream last night when I noticed that I need to do some refactoring as the check doesn't belong into the function it modifies. But functionality wise it's correct.
|
|
(Assignee) | |
Updated•9 years ago
|
||
Attachment #351320 -
Flags: review?(mozilla) → review?(vladimir)
Attachment #351320 -
Flags: review?(vladimir) → review+
Flags: blocking1.9.1? → blocking1.9.1+
|
|
(Assignee) | |
Comment 5•9 years ago
|
||
Comment on attachment 351320 [details] [diff] [review] patch for moz cairo [pushed to m-c][pushed to 1.9.1] http://hg.mozilla.org/mozilla-central/rev/e8d254e47322
Attachment #351320 -
Attachment description: patch for moz cairo → patch for moz cairo [pushed to m-c]
Attachment #351320 -
Flags: approval1.9.1?
|
|
(Assignee) | |
Updated•9 years ago
|
||
Attachment #351320 -
Flags: approval1.9.1?
|
|
(Assignee) | |
Comment 6•9 years ago
|
||
Fixed on mozilla-central. Still needs to land on 1.9.1.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
|
|
(Assignee) | |
Comment 7•9 years ago
|
||
Comment on attachment 351320 [details] [diff] [review] patch for moz cairo [pushed to m-c][pushed to 1.9.1] http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c871aaeafc34
Attachment #351320 -
Attachment description: patch for moz cairo [pushed to m-c] → patch for moz cairo [pushed to m-c][pushed to 1.9.1]
|
|
(Assignee) | |
Comment 8•9 years ago
|
||
Distributions that build 1.9.1 Beta 3 with --enable-system-cairo will need this fix in their cairo.
Keywords: fixed1.9.1
|
||
Comment 9•9 years ago
|
||
Is it fixed upstream too? I can't find it in the 1.8.6 release notes.
|
|
(Assignee) | |
Comment 10•9 years ago
|
||
(In reply to comment #9) This is being tracked upstream here: http://bugs.freedesktop.org/show_bug.cgi?id=18862
Duplicate of this bug: 490032
You need to log in
before you can comment on or make changes to this bug.
Description
•