467908 - All day event boxes in rotated view overlapps time grid and shown side by side

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Andreas Treumann]

Attachment: All day events boxes in rotated overlapps time grid

STEPS TO REPRODUCE:
===================

- create an all day event
- switch to day/week view
- go to 'View/Current View'
- enable 'rotated view'

RESULT:
=======

- the all day event box overlapps the time grid (see screen shot)

EXPECTED RESULT:
================

- the all day event box should only visible in the all day section


REPRODUCIBLE:
=============

- always

Comment 1

[Peter Weilbacher]

I could have sworn that I only saw this happen first after Xmas, but I now tested a few comm-central builds (with new profile every time) and found this:

2008-12-20-04 (Linux)  broken
2008-12-14-04 (Linux)  broken
2008-12-10-03 (Linux)  broken
2008-12-05-03 (Linux)  broken
2008-12-04-04 (Linux)  broken
2008-12-03-04 (Linux)  broken
2008-12-02-03 (Linux)  broken
2008-12-01-03 (Linux)  works

By the way, I would actually like the change that the all-day events are all aligned along the top of each day if the other events were cut down a bit. (But that's probably another bug.)

Comment 2

[Peter Weilbacher]

Judging from the comments I see in <http://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-12-01+03%3A00&enddate=2008-12-02+03%3A00> bug 416138 could be responsible. Haven't looked at the code, though.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This fixes (partially), but if the title is very long, then the box is neither cut off nor wrapped.

What do we want to do here? Not sure how easy its possible to make it automatically wrap. I don't think the part with making the header stop expanding should block the release.

Comment 4

[Stefan Sitter [:ssitter]]

Comment on attachment 361347 [details] [diff] [review]
Fix - v1

I don't think this is the correct fix. It just replaces one regression with another regression.

There should be a correct fix that restores the previous behavior, i.e. all day entries are stacked on top of each other instead of side by side.

Comment 5

[Stefan Sitter [:ssitter]]

I can confirm the regression range mentioned in comment #2.

Comment 6

[Stefan Sitter [:ssitter]]

Attachment: multiple all day boxes are shown side by side regression

This screenshot shows the previous correct behavior (stacked on top of each other) and the current wrong behavior (side by side) if multiple all day events exists on the same day.

Comment 7

[Peter Weilbacher]

Yes, the patch in my case causes the week view itself to disappear completely, because the all-day event column gets so wide that it pushes the days out of the window (because I have many all-day events with long names this week).

Comment 8

[Merike Sell (:merike)]

Attachment: 3-line fix

This fixes it for me and makes sense since the expected behaviour for header boxes is the same in both views.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 464119 [details] [diff] [review]
3-line fix

This definitely improves the situation. Ideally, if there is a box with a longer title then the daybox could auto-expand to a predefined max-width. (In a more ideal world, we could put a splitter there, but thats a different bug)
I'm happy to do both in a separate bug though.



>-calendar-header-container[orient="horizontal"] {
>+.calendar-header-day-box[orient="vertical"] .calendar-event-column-header {
Unless I'm missing a special case, since now all header day boxes are orient vertical, we can get rid of the attribute selector.

r=philipp

I forget, do you need this checked in, or do you have commit access yourself? (You should, if you don't :) Please set keywords accordingly.

Comment 10

[Merike Sell (:merike)]

(In reply to comment #9)
> Comment on attachment 464119 [details] [diff] [review]
> 3-line fix
> 
> >-calendar-header-container[orient="horizontal"] {
> >+.calendar-header-day-box[orient="vertical"] .calendar-event-column-header {
> Unless I'm missing a special case, since now all header day boxes are orient
> vertical, we can get rid of the attribute selector.
There is no bottom-border applied to that box in normal view. It should only be applied in rotated view. There is also no min-width set in normal view, I can see it go as narrow as 81px before day labels stop it.

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/8ab6d18a66d4>

-> FIXED

Comment 13

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/b4930dc6440a>

a=philipp