Closed Bug 467994 Opened 16 years ago Closed 15 years ago

drag and drop subfolder to root of account is blocked/fails

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 3.0b2

People

(Reporter: wsmwk, Assigned: iannbugzilla)

References

Details

(Keywords: regression)

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20081204 Thunderbird/3.0b1

drag and drop subfolder to root of account is blocked/fails. i.e. drag a local second level folder (subfolder) to local account to make it a first level folder

result: operation shows the drop is blocked

works if dragging subfolder to another folder
This is true on Mac too! Build 3.0b2pre
Regression from tb2, and quite limiting, as there's no way to move back a folder other than dragging and dropping, in case you move it accidentally.
Flags: blocking-thunderbird3+
Keywords: regression
OS: Windows Vista → All
Hardware: x86 → All
The reason is that the new code checks .canFileMessages regardless if it is a message or folder - http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#343
The old code used to do that check as well as a lot more.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
This patch makes canDrop only check .canFileMessages when the drop types are messages.
Attachment #357240 - Flags: review?(mkmelin+mozilla)
Blocks: 414038
Blocks: 465015
There are other checks we probably still need to do for messages that were in the old code:
targetFolder.isServer and checking not dropping into folder it is already in.
Attachment #357240 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 357240 [details] [diff] [review]
Only check .canFileMessages for messages patch v0.1 (Checkin: Comment 9)

Thx, r=mkmelin
Attachment #357240 - Flags: superreview?(bienvenu)
Attachment #357240 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 357240 [details] [diff] [review]
Only check .canFileMessages for messages patch v0.1 (Checkin: Comment 9)

thx for the patch!
Attachment #357240 - Attachment description: Only check .canFileMessages for messages patch v0.1 → Only check .canFileMessages for messages patch v0.1 (Checkin: Comment 9)
Comment on attachment 357240 [details] [diff] [review]
Only check .canFileMessages for messages patch v0.1 (Checkin: Comment 9)

http://hg.mozilla.org/comm-central/rev/47815c10e304
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
thanks Ian. 
verified 2009-01-24 build
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.