468032 - nsIURIFixup not defined (in nsMailDefaultHandler.js)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

I suspect nsIURIFixup was thought to already be defined as other constants in this file when Bug 412434 was fixed.

http://mxr.mozilla.org/comm-central/source/mail/components/nsMailDefaultHandler.js#79

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Nice. That's at least twice in this file, that I remember. Almost enough to make you think that single-use constants that don't really look like constants, tucked away in try/catch blocks, aren't a very robust pattern for untested and rarely used code.

Thanks for catching it, though :)

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 351512 [details] [diff] [review]
Fix v.1

Most of the defined short names seem to once or a few times tops... 

r=mkmelin this way or if you want to move it inline.

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/2c50e630c8a5

I'd like to move it inline, but I don't want to own the thing, so I'd rather have it be a copy of the other copies...