Closed Bug 468032 Opened 16 years ago Closed 16 years ago

nsIURIFixup not defined (in nsMailDefaultHandler.js)

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: robert.strong.bugs, Assigned: philor)

References

Details

Attachments

(1 file)

I suspect nsIURIFixup was thought to already be defined as other constants in this file when Bug 412434 was fixed.

http://mxr.mozilla.org/comm-central/source/mail/components/nsMailDefaultHandler.js#79
Attached patch Fix v.1Splinter Review
Nice. That's at least twice in this file, that I remember. Almost enough to make you think that single-use constants that don't really look like constants, tucked away in try/catch blocks, aren't a very robust pattern for untested and rarely used code.

Thanks for catching it, though :)
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #351512 - Flags: review?(mkmelin+mozilla)
Summary: nsIURIFixup not defined → nsIURIFixup not defined (in nsMailDefaultHandler.js)
Comment on attachment 351512 [details] [diff] [review]
Fix v.1

Most of the defined short names seem to once or a few times tops... 

r=mkmelin this way or if you want to move it inline.
Attachment #351512 - Flags: review?(mkmelin+mozilla) → review+
http://hg.mozilla.org/comm-central/rev/2c50e630c8a5

I'd like to move it inline, but I don't want to own the thing, so I'd rather have it be a copy of the other copies...
Target Milestone: --- → Thunderbird 3.0b2
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.