runtests.py should attempt to determine CPU architecture based on the avmshell

VERIFIED FIXED

Status

Tamarin
Build Config
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Brent Baker, Assigned: Brent Baker)

Tracking

({flashplayer})

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Since windows64 and mac are able to run both 32bit and 64bit executables, relying on what python reports as the cpu type can be inaccurate since it will report as being 32bit. However if we used 'file' to acquire information about the executable then we could set the "cputype" more accurately.

Need to fall back to current implementation if "file" is not available on the system.
(Assignee)

Updated

9 years ago
Assignee: nobody → brbaker
Status: NEW → ASSIGNED
(Assignee)

Comment 1

9 years ago
Created attachment 351543 [details] [diff] [review]
determine cputype based on avmshell executable

Also update the ostype check to be a little more relaxed, don't need EXACT full string match (removes multiple checks for cygwin versions). 

Removed the win64 ostype, since it should just be 'win' with a cputype of 'x64' a.k.a. 'x64-win'
Attachment #351543 - Flags: review?(dschaffe)

Updated

9 years ago
Attachment #351543 - Flags: review?(dschaffe) → review+
(Assignee)

Comment 2

9 years ago
Pused redux 1199:6788c138004b
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.