468170 - Menu entry "Help > Release Notes" opens in same tab instead of new one

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2

When choosing the Release Notes entry under the help menu the notes doesn't open in a new tab as all the other entries do. We should have the same behavior here for each of the website links.

Comment 2

[Michael Kohler [:mkohler]]

Attachment: Patch v1

something else we have to do or is this enough?

Comment 3

[Michael Kohler [:mkohler]]

Attachment: Patch v2

better like that?

Comment 4

[Dão Gottwald [:dao]]

Fixed on trunk:

http://hg.mozilla.org/mozilla-central/rev/c51743ebbe59

... feel free to request approval for the 1.9.1 branch.

Comment 5

[Dão Gottwald [:dao]]

And fixed the comment:

http://hg.mozilla.org/mozilla-central/rev/93386d946d36

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 369585 [details] [diff] [review]
Patch v2

a191=beltzner

Comment 7

[Michael Kohler [:mkohler]]

see comment 5 for additional "patch".

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/dc7f9e777877
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d7ecf0ea1bff

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on trunk and 1.9.1 with builds on Windows and OS X:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090416 Minefield/3.6a1pre ID:20090416030845

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5;
en-US; rv:1.9.1b4pre) Gecko/20090416 Shiretoko/3.5b4pre ID:20090416030924