Closed Bug 468174 Opened 16 years ago Closed 16 years ago

TM: tracing .call() breaks TUnit xml_serialize and xml_parser

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: gal, Unassigned)

Details

(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

patch
2.47 KB, patch
brendan
: review+
sayrer
: approval1.9.1+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
      No description provided.
Comment on attachment 351626 [details] [diff] [review]
patch

For both call and apply the target argc is 0 if call and apply don't at least have 2 arguments, so in that case don't try to copy and prepare arguments for call.
Attachment #351626 - Flags: review?(brendan)
Comment on attachment 351626 [details] [diff] [review]
patch

>+            argv = (LIns**)alloca(sizeof(LIns*) * argc);

Prevailing style wants a space after that cast. New C++ style is ok with type and * cuddling ;-).

>             argv = (LIns**)alloca(sizeof(LIns*) * argc);

Ditto.

r=me with those nits picked.

/be
Attachment #351626 - Flags: review?(brendan) → review+
Landed in TM: http://hg.mozilla.org/tracemonkey/rev/430443243820

Closing directly this the buggy patch never MC.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-tracemonkey
Attachment #351626 - Flags: approval1.9.1?
Attachment #351626 - Flags: approval1.9.1? → approval1.9.1+
Flags: in-testsuite?
suggestions on how to test this welcomed.
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: