468254 - duplicate registry entries for seamonkey quick launch

Status: RESOLVED WONTFIX

(SeaMonkey :: Installer, defect)

Description

[Carlos Une]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pt-BR; rv:1.8.1.19) Gecko/20081204 SeaMonkey/1.1.14
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pt-BR; rv:1.8.1.19) Gecko/20081204 SeaMonkey/1.1.14

If I enable QuickLaunch while installing SeaMonkey 1.1.14 (win32-installer.exe), it will create a value called "SeaMonkey Quick Launch" in Windows Registry. Then I launch SeaMonkey and click on Edit - Preferences - Advanced. "Keep SeaMonkey in memory to improve startup performance" is not enabled. If I enabled it, it will create another value, "Mozilla Quick Launch". It is not possible to remove the first one without using regedit.

Reproducible: Always

Steps to Reproduce:
1. enable quick launch in windows installer
2. enable "Keep SeaMonkey in memory to improve startup performance"
3. disable "Keep SeaMonkey in memory to improve startup performance"
4. reboot windows
Actual Results:  
seamonkey is loaded during windows startup

Comment 1

[Justin Wood (:Callek)]

Frank, do we feel this would be easy/worthwhile to fix on our stable banch?

(Note: He selects it in installer then selects it in prefs)

Comment 2

[Frank Wein [:mcsmurf]]

The problem is:
Installer does this http://mxr.mozilla.org/mozilla1.8/source/xpinstall/packager/windows/browser.jst#217
valname = "SeaMonkey Quick Launch";
[...]
winreg.setValueString(subkey, valname, newKey)

Pref window does this http://mxr.mozilla.org/mozilla1.8/source/xpfe/components/prefwindow/resources/content/pref-advanced.xul#100
document.getElementById("enableTurbo").checked = parent.isTurboEnabled;
-> http://mxr.mozilla.org/mozilla1.8/source/xpfe/components/winhooks/nsWindowsHooks.cpp#703
  nsWindowsHooks::IsOptionEnabled
[...]
    RegistryEntry startup ( HKEY_CURRENT_USER, RUNKEY, NS_QUICKLAUNCH_RUN_KEY, NULL );
     nsCString cargs = startup.currentSetting();

-> #define NS_QUICKLAUNCH_RUN_KEY "Mozilla Quick Launch"

Note "Mozilla"<->"SeaMonkey"

Comment 3

[Justin Wood (:Callek)]

(In reply to comment #2)
> -> #define NS_QUICKLAUNCH_RUN_KEY "Mozilla Quick Launch"
> 
> Note "Mozilla"<->"SeaMonkey"

So worth s/Mozilla/SeaMonkey/ in that define?

Would that fix this?

Comment 4

[Carlos Une]

(In reply to comment #3)
> (In reply to comment #2)
> > -> #define NS_QUICKLAUNCH_RUN_KEY "Mozilla Quick Launch"
> > 
> > Note "Mozilla"<->"SeaMonkey"
> 
> So worth s/Mozilla/SeaMonkey/ in that define?
> 
> Would that fix this?

For information, the same situation happens with seamonkey-1.1.en-US.win32.installer.exe. So if you change it, users of previous versions won't be able to delete the "Mozilla Quick Launch" key.

Comment 5

[Philip Chee]

Closing as WONTFIX for the time being as the 1.8.1 branch will only take securitya and stability fixes. Please reopen if you can get the concurrence of the SeaMonkey Council.