468290 - Success message is missing file status when uploading additional files for a version.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Success message is missing file status when uploading additional files for a version.

Steps to Reproduce:

1. Load https://addons.mozilla.org/en-US/developers/versions/edit/45973 (Justin, I've made you an Owner.)
2. Click "Add New File"
3. Choose "Archive.xpi" and click "Upload File"

Actual Results:

"Your new file has been added to version 2.0 and is currently marked as ."

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

As a side note, I can't log in to http://remora-3.5.php5stage.mozilla.com/en-US/firefox/ any longer :-(.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Archive.xpi

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Another screenshot; this time with multiple "Add to Firefox" buttons

fligtar, would you mind taking a look whenever you have a free moment?

Comment 5

[u278084]

Attachment: catch sandox-only addons

These seems to be caused when you upload a new version of a sandbox only addon, one that has not been nominated. An if-else if statement didn't catch sandox only addons.

Addons that have been marked disabled seem to throw the right message. So I think we're fine for all the different statuses an addon could be under when uploaded. But I could be wrong.

Comment 6

[u278084]

Thanks for the review Justin. My development box is not on the network, so I can't check this in. If anyone can for me, that will be appreciated. I think this has to be checked in for both 3.5 and trunk.

Comment 7

[u278084]

A sufficiently lengthy extension cable solved my network issue. In both trunk and 3.5. r22761

Comment 8

[Wil Clouser [:clouserw]]

(In reply to comment #7)
> A sufficiently lengthy extension cable solved my network issue. In both trunk
> and 3.5. r22761

Thanks, No need to change the 3.5 branch.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/developers/versions/add/9602 and https://preview.addons.mozilla.org/en-US/firefox/addons/versions/9602