Shouldn't be necessary for nsLocalMoveCopyMsgTxn to implement QueryInterface

RESOLVED FIXED in Thunderbird 3.0b2

Status

MailNews Core
Backend
--
minor
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
Thunderbird 3.0b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
An nsLocalMoveCopyMsgTxn is only created in one place but it is then assigned to a member variable of type nsMsgTxn so that it has to be "cast" back. Instead the member should simply be declared to be of the correct type.
(Assignee)

Comment 1

9 years ago
Created attachment 351813 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #351813 - Flags: superreview?(bienvenu)
Attachment #351813 - Flags: review?(bienvenu)
(Assignee)

Comment 2

9 years ago
Created attachment 351816 [details] [diff] [review]
Kill the #define too

After reviewing bug 65775 I realised that I'd left it in by mistake ;-)

Comment 3

9 years ago
Comment on attachment 351816 [details] [diff] [review]
Kill the #define too

thx, Neil.
Attachment #351816 - Flags: superreview+
Attachment #351816 - Flags: review+

Updated

9 years ago
Attachment #351813 - Attachment is obsolete: true
Attachment #351813 - Flags: superreview?(bienvenu)
Attachment #351813 - Flags: review?(bienvenu)

Comment 4

9 years ago
Comment on attachment 351813 [details] [diff] [review]
Proposed patch

obsoleting in favor of second patch.
(Assignee)

Comment 5

9 years ago
Pushed changeset 8e8a945d3230 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.