Closed Bug 468399 Opened 11 years ago Closed 11 years ago

use image surfaces on wince

Categories

(Core :: Widget: Win32, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

image surfaces appear to be much faster than window surfaces.  Timing shows a reduction of OnPaint from ~700ms to ~500ms.
Attachment #351852 - Flags: review?(vladimir)
also, (as mfinkle pointed out) is there any reason why we wouldn't just use image surfaces everywhere?
Comment on attachment 351852 [details] [diff] [review]
use image surfaces

Looks good -- also check nsThebesImage.cpp, since it does some special stuff for win32 and creates gfxWindowSurfaces directly; you can get rid of that.
Attachment #351852 - Flags: review?(vladimir) → review+
vlad, should we use MOZ_GFX_OPTIMIZE_MOBILE instead of #ifdef WINCE?
vlad, one more thing.  in nsThebesImage, we are already no creating window surfaces because this predicate always returns failure on wince:

http://mxr.mozilla.org/mozilla-central/source/gfx/src/thebes/nsThebesImage.cpp#697
Flags: wanted1.9.1?
mc: a9ce401fe056

this is required for windows mobile performance.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #351852 - Flags: approval1.9.1?
Attachment #351852 - Flags: approval1.9.1? → approval1.9.1+
this landed on 1.9.1, clearing request flag.
Flags: wanted1.9.1?
You need to log in before you can comment on or make changes to this bug.