468419 - Minefield titlebar icons missing since Bug 467038

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect, P1)

Description

[Ria Klaassen (not reading all bugmail)]

I see only Default Windows icons. Not only the main window icon is gone, but also the ones of add-ons window, library etc.
If you place the icons in the application's chrome\icons\default folder they are still applied.

Comment 1

[Ria Klaassen (not reading all bugmail)]

The same in Windows Vista.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: patch

Oops, I should have loaded icon from our module rather than system default.

Comment 3

[u88484]

For the record.  On Vista only the title bar icon is missing.  The add-ons, customize and library icons are still normal.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We need this landed ASAP, this is a critical regression.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed 44a63976fe9a

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

Verified fixed using hourly build:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20081209 Minefield/3.2a1pre Firefox/3.0.4 ID:20081209014420

Comment 7

[:Gavin Sharp [email: [e-mail]]]

As far as I can tell, this bug doesn't need to block 1.9.1, since the patch for bug 467038 which caused it isn't going to land there. I'll comment there to make sure this fix isn't forgotten if it does.