468507 - Use DrawCellWithSnapping when drawing push buttons

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

This patch is on top of that in bug 462233.

Comment 1

[Markus Stange [:mstange]]

Attachment: v2, always use 0.5 as offset factor

Looking at the vertical align property in order to determine the snapping direction is a bad idea, since the text on the button might not be centered in the button any more.
Now I always center it.

Comment 2

[Markus Stange [:mstange]]

Attachment: Screenshot of google.de with patch

Note that the buttons aren't blurry any more.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Markus, will this also fix bug 384830?  (There's also a bug out there, or maybe just a comment in a related bug, about the blurriness of the current scaling, though I can't find it right now.)

Comment 4

[Markus Stange [:mstange]]

(In reply to comment #3)
> Markus, will this also fix bug 384830?

I think that bug is already fixed.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 351973 [details] [diff] [review]
v2, always use 0.5 as offset factor

sr=dbaron, although if there was something particularly interesting that you wanted my opinion about, you should ask me explicitly...

Comment 6

[Markus Stange [:mstange]]

Attachment: for checkin

Comment 7

[Markus Stange [:mstange]]

pushed: http://hg.mozilla.org/mozilla-central/rev/a4cc5f89569d

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 356477 [details] [diff] [review]
for checkin

Small polish fix (buttons in their default size no longer look blurry), quite safe.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 356477 [details] [diff] [review]
for checkin

a191=beltzner

Comment 10

[Markus Stange [:mstange]]

pushed to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fccdbc78ede6