nsIDocShell interace refactoring.

VERIFIED FIXED in mozilla0.9.2

Status

()

Core
Embedding: APIs
P1
normal
VERIFIED FIXED
18 years ago
16 years ago

People

(Reporter: Judson Valeski, Assigned: Adam Lock)

Tracking

Trunk
mozilla0.9.2
x86
Windows 98
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta3-])

(Reporter)

Description

18 years ago
nsIDocShell is not going to be public, we need to move what we need up.


          Move up (copy) anything we need from here for the top-level content
          doc to nsIWebNavigation, nsIWebBrowserSetup, etc. 
          Remove the docshell attribute from nsIWebBrowser. In a pinch it can be
          obtained by QIing to nsIDocShellTreeOwner 
          Add a getter to nsIWebBrowser for nsIDOMWindow or
          nsIDOMDocument for the top-level content. 
     loadURI doesn't need to be noscript. An equivalent already exists on
     WebNavigation 
     Stop() on WebNavigation should be able to specify what to stop 
     Can we get rid of presContext, presShell? 
     Move subset of documentCharsetInfo up to nsIWebNavigation 
     allowPlugins to nsIWebBrowserSetup - maybe flags for general control of
     plugins, applets, etc. (really just a shortcut for prefs?) 
     May want to get rid of viewMode attribute and move purely to view-source:
     (implemented by Adam). The external interface should only be able to do 
view
     source by prepending a view-source: to the loaded URL.
(Reporter)

Updated

18 years ago
Keywords: embed

Updated

18 years ago
Keywords: nsbeta3
(Reporter)

Updated

18 years ago
Whiteboard: [nsbeta3+]
(Reporter)

Updated

18 years ago
Target Milestone: --- → M18
(Reporter)

Updated

17 years ago
Priority: P3 → P1

Comment 1

17 years ago
per email with Jud, changing nsbeta3+ to nsbeta3- on all "embed" keyword bugs
since embedding changes will not be made in the mn6 branch. If you feel this bug
fix needs to go into mn6 branch, please list the reasons/user impact/risk and
nominate for rtm. Thanks.
Whiteboard: [nsbeta3+] → [nsbeta3-]

Comment 2

17 years ago
Updating QA Contact
QA Contact: jrgm → mdunn

Updated

17 years ago
Target Milestone: M18 → ---
(Reporter)

Updated

17 years ago
Target Milestone: --- → mozilla0.9.1
(Reporter)

Updated

17 years ago
Keywords: embed

Comment 3

17 years ago
Correction: Changing QA contact for the Embed API bugs to David Epstein.
QA Contact: mdunn → depstein

Comment 4

17 years ago
->adam
Assignee: rpotts → adamlock
(Reporter)

Updated

17 years ago
Target Milestone: mozilla0.9.1 → mozilla0.9.2
(Assignee)

Comment 5

17 years ago
This has all been done right?
(Assignee)

Comment 6

17 years ago
FIXED
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 7

17 years ago
verifying wrt Jud's notes above. per questions about #4 and #8, I'm reopening. 
If these are OK, then change status back to resolved and I'll verify as OK. 
Thanks.
1) content attributes in nsIWebNavigation. Plugins, subframes, js support in 
nsIWebBrowserSetup. 
2) docshell attribute is no longer in nsIWebBrowser.
3) attribute is in nsIWebBrowser for nsIDOMWindow to access top-level DOM 
window.
4) but in nsIDocShell.idl, loadURI IS still noscript. 
5) Stop() in nsIWebNavigation stops a url. Doesn't appear to be dependent on the 
docShell.
6) In nsIDocShell, the nsIDocumentCharsetInfo iface is called and contains a 
boolean attribute of this type.
7) In nsIDocShell, there's allowPlugins boolean attribute.
8) presContext and presShell attributes are still in there. Were they meant to 
be removed?
9) viewMode attribute removed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 8

17 years ago
done
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED

Comment 9

17 years ago
verifying
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.