46854 - nsIDocShell interace refactoring.

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect, P1)

Description

[Judson Valeski]

nsIDocShell is not going to be public, we need to move what we need up.


          Move up (copy) anything we need from here for the top-level content
          doc to nsIWebNavigation, nsIWebBrowserSetup, etc. 
          Remove the docshell attribute from nsIWebBrowser. In a pinch it can be
          obtained by QIing to nsIDocShellTreeOwner 
          Add a getter to nsIWebBrowser for nsIDOMWindow or
          nsIDOMDocument for the top-level content. 
     loadURI doesn't need to be noscript. An equivalent already exists on
     WebNavigation 
     Stop() on WebNavigation should be able to specify what to stop 
     Can we get rid of presContext, presShell? 
     Move subset of documentCharsetInfo up to nsIWebNavigation 
     allowPlugins to nsIWebBrowserSetup - maybe flags for general control of
     plugins, applets, etc. (really just a shortcut for prefs?) 
     May want to get rid of viewMode attribute and move purely to view-source:
     (implemented by Adam). The external interface should only be able to do 
view
     source by prepending a view-source: to the loaded URL.

Comment 1

[lchiang]

per email with Jud, changing nsbeta3+ to nsbeta3- on all "embed" keyword bugs
since embedding changes will not be made in the mn6 branch. If you feel this bug
fix needs to go into mn6 branch, please list the reasons/user impact/risk and
nominate for rtm. Thanks.

Comment 2

[Paul Wyskoczka]

Updating QA Contact

Comment 3

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 4

[rpotts (gone)]

->adam

Comment 5

[Adam Lock]

This has all been done right?

Comment 6

[Adam Lock]

FIXED

Comment 7

[David Epstein]

verifying wrt Jud's notes above. per questions about #4 and #8, I'm reopening. 
If these are OK, then change status back to resolved and I'll verify as OK. 
Thanks.
1) content attributes in nsIWebNavigation. Plugins, subframes, js support in 
nsIWebBrowserSetup. 
2) docshell attribute is no longer in nsIWebBrowser.
3) attribute is in nsIWebBrowser for nsIDOMWindow to access top-level DOM 
window.
4) but in nsIDocShell.idl, loadURI IS still noscript. 
5) Stop() in nsIWebNavigation stops a url. Doesn't appear to be dependent on the 
docShell.
6) In nsIDocShell, the nsIDocumentCharsetInfo iface is called and contains a 
boolean attribute of this type.
7) In nsIDocShell, there's allowPlugins boolean attribute.
8) presContext and presShell attributes are still in there. Were they meant to 
be removed?
9) viewMode attribute removed.

Comment 8

[Judson Valeski]

done

Comment 9

[David Epstein]

verifying