Closed Bug 468543 Opened 16 years ago Closed 15 years ago

form autocomplete (and Firefox search bar) items are sorted case sensitively (A-Za-z)

Categories

(Toolkit :: Form Manager, defect)

Product:
Toolkit
Component:
Form Manager
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: alex, Assigned: Gavin)

References

Details

(Keywords: verified1.9.0.9, verified1.9.1)

Attachments

(1 file)

patch
1.08 KB, patch
sdwilsh
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4

The firefox search box seems to do a non-smart ordering of previous searches.
I get [A-Z<symbols>a-z].
I think it should not differentiate between upper & lower case for the sorting (or treat both cases of a letter as adjacent letters) -- although it should still preserve case for all searches.

Reproducible: Always

Actual Results:  
A
Z
"
/
a
z

Expected Results:  
A
a
B
b
"
/
I see this bug too, and it doesn't seem to be a duplicate.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20081210 Minefield/3.2a1pre
Status: UNCONFIRMED → NEW
Ever confirmed: true
With Firefox 3.0 on Ubuntu 8.04. Actual Results:
"
/
A
Z
a
z
Shawn: I think this is just the result of the sort at:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/src/nsStorageFormHistory.cpp#553

Is there an alternative we can use that will get us a case-insensitive sort?
You'll want to use LIKE to get case insensitivity.
Misread the above - this should shine some light on things:
sqlite> select * from foo order by n ASC;
A
B
C
a
b
c
sqlite> select * from foo order by UPPER(n) ASC;
A
a
B
b
C
c
Attached patch patch — — Splinter Review 
No noticeable slowdown when listing my entire 8382-item searchbar history (which is a pretty pathological case as far as forms are concerned).
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #356981 - Flags: review?(sdwilsh)
(noe
Component: Search → Form Manager
OS: Windows Vista → All
Product: Firefox → Toolkit
QA Contact: search → form.manager
Hardware: x86 → All
Version: unspecified → Trunk
Summary: search box does case sensitive sort (A-Za-z) of old searches → form autocomplete (and Firefox search bar) items are sorted case sensitively (A-Za-z)
Comment on attachment 356981 [details] [diff] [review]
patch

r=sdwilsh
Attachment #356981 - Flags: review?(sdwilsh) → review+
I have a partially completed test for this somewhere...
Flags: in-testsuite?
https://hg.mozilla.org/mozilla-central/rev/c3d462ead823
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 356981 [details] [diff] [review]
patch

Requesting approval for a low-risk patch to improve the user experience of form autocomplete
Attachment #356981 - Flags: approval1.9.1?
Comment on attachment 356981 [details] [diff] [review]
patch

a=beltzner, but gavin promised me a test!
Attachment #356981 - Flags: approval1.9.1? → approval1.9.1+
This fix landed on 1.9.0.8 as part of bug 483096.
Keywords: fixed1.9.0.8
Verified for 1.9.0.8 as part of bug 483096.
Keywords: fixed1.9.0.8 → verified1.9.0.8
Gavin, plans to land this on 1.9.1?
Yes, I just wanted to write the test for it.
verified FIXED on builds: 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090505 Minefield/3.6a1pre ID:20090505030940

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090505 Shiretoko/3.5b5pre ID:20090505030932
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: